Archy-X / AuraSkills

The ultra-versatile RPG skills plugin
https://aurelium.dev/auraskills
GNU General Public License v3.0
235 stars 88 forks source link

Disenchanter experience is not given if item is taken out with item on the cursor #282

Closed Leomelonseeds closed 3 months ago

Leomelonseeds commented 3 months ago

Server software and version

Paper 1.20.4

Expected behavior

While looking through the code for the Disenchanter Forging ability as reference for something, I noticed a line of code here that is not necessary: https://github.com/Archy-X/AuraSkills/blob/9b553b53f19de8742a867e93582863f8ec2f7b4e/bukkit/src/main/java/dev/aurelium/auraskills/bukkit/skills/forging/ForgingAbilities.java#L62. This is because shift-clicking items from the Grindstone result slot to your own inventory still works if you have an item in your cursor. Quite a specific, niche bug but I felt it would be good to report nonetheless.

Actual behavior

See title.

How to reproduce

Evident through code.

Additional information

No response

Agreements

Archy-X commented 3 months ago

This should be fixed in 2.1.0