Archy-X / AuraSkills

The ultra-versatile RPG skills plugin
https://aurelium.dev/auraskills
GNU General Public License v3.0
239 stars 92 forks source link

Block Duplication Bug When Using AuraSkills with ItemsAdder #289

Open G-JLING opened 4 months ago

G-JLING commented 4 months ago

Server software and version

Paper 1.20.1

Expected behavior

Mining the block should drop the correct number of items without duplication.

Actual behavior

Mining the block results in multiple drops of the same item, leading to duplication.

How to reproduce

  1. Ensure the server is running Paper 1.20.1 with the latest builds of AuraSkills and ItemsAdder installed.
  2. Configure a profession in AuraSkills to gain experience from a specific block (e.g., "miner" from "ancient_debris").
  3. Place a note_block and then place the specific block (e.g., "ancient_debris") next to it.
  4. Mine the specific block.
  5. Observe that multiple identical blocks are dropped.

Additional information

Removing either AuraSkills or ItemsAdder resolves the issue, but this is not ideal as both plugins are needed for the server's functionality.

截屏2024-06-05 18 17 44

Agreements

Archy-X commented 4 months ago

ItemsAdder might be canceling the BlockPlaceEvent and using their own, so AuraSkills can't detect the ancient debris as a player placed block. I believe ItemsAdder has a CustomBlockPlaceEvent for this but it's hard to know what's going on since its closed source and I can't test it. Anyone can feel free to PR to add support if they need this quickly.

G-JLING commented 4 months ago

OK. Thank you for your response.

Perwollnt commented 4 months ago

If you are willing to test what I made I can create a custom fork that attempts to fix this.