Archy-X / AuraSkills

The ultra-versatile RPG skills plugin
https://aurelium.dev/auraskills
GNU General Public License v3.0
235 stars 88 forks source link

Reload modifiers on remove a tick later #304

Closed ErikSzabo closed 1 month ago

ErikSzabo commented 1 month ago

This fixes compatibility issues with libreforge (eco). I don't see any places where this would cause any problems internally (though I might be wrong). There is a strange effect when libreforge add_stat effect for the health stat causes the player taking damage non stop, because the effect gets reloaded on every inventory event or even on health regen events.

Libreforge reload looks like this:

Other possible resolutions from the libreforge side of things:

I will make this PR a draft. I don't actually want this to be merged since this is very much fixable from the libreforge side and I think it should be fixed there.

In the meantime if anyone really needs a quick fix, build this PR, it will fix the health issue, but use it at your own risk. I haven't tested every internal behavior so it might cause issues. Not likely, but there is always a chance.

ErikSzabo commented 1 month ago

Closing since it is now fixed from the libreforge side.