search

Arcitectus / Sanderling

APIs and libraries to read information directly from the EVE Online game client.
https://forum.botlab.org
Apache License 2.0
259 stars 117 forks source link

Fixing mad click in sample miner script #27

Closed philtreF closed 4 years ago

philtreF commented 7 years ago

Hi,

I added some code in DefenseStep in order to count the number of drones which are currently fighting.

This makes me able to prevent miner bot to mad click "Engage NPC" : It is needed to click on "Engage target" only when the number of drones in space is not equal with the number of drone which are currently fighting.

This is my first contribution to this project, do not hesitate to give me feedback on ways to improve for next contributions.

rh-fred.

Viir commented 7 years ago

Thank you for the changes to the mining script.

I do not understand why the changes are divided into two commits. The message from c55e52e ready like it only changes whitespaces. Why not squash c8bc277 and c55e52e into one commit?

philtreF commented 7 years ago

About the variable scope, I used to print the value in main Host.Log that is why it is there.

I will correct all theses, merge commits (didn"t know this is possible) and tell you when it will be done.

tetreum commented 7 years ago

@fhilpert any progress?