search

Arcitectus / Sanderling

APIs and libraries to read information directly from the EVE Online game client.
https://forum.botlab.org
Apache License 2.0
260 stars 117 forks source link

Add support for root-address flag when reading from saved sample #85

Closed ComeInRage closed 9 months ago

ComeInRage commented 11 months ago

Add support for root-address flag when reading from saved sample.

Sanderling does not support --root-address flag and ignores it when reading from saved process sample. With support for the --root-address flag, it is no longer necessary to run a search for UIRoot candidates. It is enough to specify the address. Also it speeds up the program execution when root-address is known.

Viir commented 9 months ago

Thank you for sharing your suggestion! It sounds sensible, but the code in commit 9c172c351977eb2b4ad867b91b9083b6fdb236f2 seems to add too much unecessary maintenance costs. For example, I don't see a reason to have more than one instance of these statements:

                    var processSampleId = Pine.CommonConversion.StringBase16FromByteArray(
                        Pine.CommonConversion.HashSHA256(processSampleFile));

                    Console.WriteLine($"Reading from process sample {processSampleId}.");

I am not sure the problems caused by such a duplication are necessary.

ComeInRage commented 9 months ago

Thank you for your response. I am not good at C#, so I suggested a minimal working solution based on my skills.

Viir commented 9 months ago

Thank you, I will merge this as it is now.