search

Arcitectus / Sanderling

APIs and libraries to read information directly from the EVE Online game client.
https://forum.botlab.org
Apache License 2.0
258 stars 117 forks source link

Skip process sampling when process Id is processId is provided #86

Closed ranc1 closed 3 months ago

ranc1 commented 4 months ago

To address issue in: https://github.com/Arcitectus/Sanderling/issues/83#issue-1813049189 This code change will:

  1. Reduces the memory (<2G) as it does not "read content" when calling ReadCommittedMemoryRegionsFromProcessId.
  2. Speeds up the root search step by a little (~20 seconds) when processId is provided.
  3. Removes dependency on the screenshots, so the command does not fail even when the window is not focused.
Viir commented 3 months ago

Thank you for sharing this improvement! Looks good to me 👍