This is more for @watabou's share of the code (upstream), but I'm posting here as this repo seems to be where the activity is.
In ~300 games I'm not aware of having run into the Scroll of Weapon Upgrade" once, which I assumed was simply because it was super rare or that there was some trick like the Potion of Might. I recently found myself looking at the Scrolls Catalogus before trying an unidentified one however, and there were two that I hadn't seen including the Scroll of Weapon Upgrade and one other one. I then used the scroll, which turned out to be the one that wasn't the Scroll of Weapon Upgrade, and somehow I was then awarded the All scrolls identified badge, and when I went into the Scrolls Catalogus the Scroll of Weapon Upgrade** scroll was shown as identified too... I'm not 100% certain that you don't simply identify the final one out of a process of elimination, but I'm pretty certain the potions don't work like that...
Anyway, I just thought I'd mention this in case it turned out to be a bug and not my own error :)
This is more for @watabou's share of the code (upstream), but I'm posting here as this repo seems to be where the activity is.
In ~300 games I'm not aware of having run into the Scroll of Weapon Upgrade" once, which I assumed was simply because it was super rare or that there was some trick like the Potion of Might. I recently found myself looking at the Scrolls Catalogus before trying an unidentified one however, and there were two that I hadn't seen including the Scroll of Weapon Upgrade and one other one. I then used the scroll, which turned out to be the one that wasn't the Scroll of Weapon Upgrade, and somehow I was then awarded the All scrolls identified badge, and when I went into the Scrolls Catalogus the Scroll of Weapon Upgrade** scroll was shown as identified too... I'm not 100% certain that you don't simply identify the final one out of a process of elimination, but I'm pretty certain the potions don't work like that...
Anyway, I just thought I'd mention this in case it turned out to be a bug and not my own error :)
Thanks, and cheers!