Closed learner-long-life closed 4 years ago
Issue Status: 1. Open 2. Started 3. Submitted 4. Done
This issue now has a funding of 0.518 ETH (75.03 USD @ $144.84/ETH) attached to it as part of the invisible-college fund.
Issue Status: 1. Open 2. Started 3. Submitted 4. Done
Work has been started.
These users each claimed they can complete the work by 4 weeks from now. Please review their action plans below:
1) owonwo has been approved to start work.
Fork the repository. Understand the codebase. Implement the UI and Interactions as expected. Deploy to my netlify account.
Learn more on the Gitcoin Issue Details page.
hi @owonwo can you provide links to your past work online, preferrably deployed as websites? Thanks.
Thank you @cryptogoth. But I the link to the first mockup doesn't work, it says 404.
Thanks @owonwo impressive work and very similar to what's needed for this task, you're cleared to start. Oops about the figma link, I'll ask the original designer @seichris to make the document public. Another thing: the bounty deadline got recorded incorrectly somehow, but I'd like to complete the work by next Thursday, not one month from now. Hope that works for you as well.
I'll be more certain when I see the first mockup. Thanks @cryptogoth
@owonwo can you try this link to the editable Figma, and request access? https://www.figma.com/file/46KvltxYaEXPazXweqQIEV/Confidential-Transfer-Demo?node-id=31%3A2
Still shows 404.
Hmm... strange. Can you send me your email address and I'll invite you to the Figma? You can delete it from this github thread afterwards. You'll need to create Figma account if you don't have one already in order to view the mockup.
Okay I think I have a publicly viewable link now https://www.figma.com/file/eiVedZmhOLoHh4WAQgleTQ/Confidential-Transfer-Demo-Copy
Please try again. I'll add your email as well.
You can click the "Play" button in the top right to view the interactive click-through demo.
Ok.
@cryptogoth @owonwo The link to the original file should be accessible again https://www.figma.com/file/46KvltxYaEXPazXweqQIEV/Confidential-Transfer-Demo?node-id=31%3A2
Thanks Chris, I was able to make a copy as well.
On Dec 13, 2019, 1:03 PM, at 1:03 PM, Chris Seifert notifications@github.com wrote:
@cryptogoth @owonwo The link to the original file should be accessible again https://www.figma.com/file/46KvltxYaEXPazXweqQIEV/Confidential-Transfer-Demo?node-id=31%3A2
-- You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub: https://github.com/invisible-college/democracy/issues/39#issuecomment-565544920
@cryptogoth I didn't find the Inter font on google. So I downloaded it for local use, hope that's fine with you?
hi @owonwo that's ok, we can substitute a similar, freely available font in the final implementation. Don't worry about it for now.
Do these represent images or just a badge? If it's a badge is it allowed to only contain 3 chars? @cryptogoth
It's meant to be text with a circular border, like with CSS border radius for maximum rounded corners of an HTML element. Thanks for asking. They are between 2 and 4 characters, but almost always 3 characters, and you can assume it's 3 for now
On Dec 17, 2019, 6:17 PM, at 6:17 PM, Joseph Owonvwon notifications@github.com wrote:
Do these represent images or just a badge? If it's a badge is it allowed to only contain 3 chars?
-- You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub: https://github.com/invisible-college/democracy/issues/39#issuecomment-566792613
@cryptogoth Thoughts Please: https://vigilant-wiles-4b7d39.netlify.com/
Wonderful @owonwo it is very true to the mockup, and the switch from Step 1 to Step 2 focuses attention in the right way. I like the "James Cameron" name, nice Avatar ref :)
How did you feel about the experience of coding this up? Was there anything you thought could be more effective for the user in this interaction, or anything from the mockup or bounty description that could be more clear for you?
Some requested changes: 1) when you hover over a particular token's row (you shouldn't have to click on it), and the total next to it changes to an arrow, all the other arrows for other tokens should disappear, and the total amount should be displayed again.
That is, only one arrow should be displayed at a time.
2) When you change to Step 2, can you make all of the Step 1 column grayed out and unclickable / unfocusable?
3) Finally, can you add a third column, to display transaction success / failure messages? They can also just be static text for now. As in the rightmost part of this mockup
Wonderful @owonwo it is very true to the mockup, and the switch from Step 1 to Step 2 focuses attention in the right way. I like the "James Cameron" name, nice Avatar ref :)
How did you feel about the experience of coding this up? Was there anything you thought could be more effective for the user in this interaction, or anything from the mockup or bounty description that could be more clear for you?
Some requested changes:
1. when you _hover_ over a particular token's row (you shouldn't have to click on it), and the total next to it changes to an arrow, all the other arrows for other tokens should disappear, and the total amount should be displayed again.
That is, only one arrow should be displayed at a time.
1. When you change to Step 2, can you make all of the Step 1 column grayed out and unclickable / unfocusable? 2. Finally, can you add a third column, to display transaction success / failure messages? They can also just be static text for now. As in the rightmost part of this mockup
I don't understand the 3 index. @cryptogoth Where does it apply?
@owonwo sorry i meant to include this second mockup, which was in the original bounty description, but further down https://www.figma.com/file/KEV19jwlvgd3m9lexQx9KL/Confidential-Transfer-Demo?node-id=0%3A1
It goes to the right of Step 2.
Ok. I've updated the link @cryptogoth
Thanks @owonwo the arrow / amount interaction works great, and I'll move the remaining changes I requested to the next bounty. I can tell you put a lot of work into this one. We can call this task done as soon as you create a pull request and add your source code to the repo.
Which branch should i make a PR to? @cryptogoth
@owonwo you can create your own branch. you might have to fork the repo first, commit your files to the fork/branch, then you can create a PR against that. Hope that makes sense.
@owonwo you can create your own branch. you might have to fork the repo first, commit your files to the fork/branch, then you can create a PR against that. Hope that makes sense.
I tried. It didn't work @cryptogoth
You could create an orphan branch so I can pull it there instead. 😅
@owonwo sorry to hear about the troubles. Did you try forking first? This is an example of another PR created by another gitcoin contributor https://github.com/invisible-college/democracy/pull/34
I have made the PR @cryptogoth . #40
@cryptogoth I have seen the merge. So what happens next?
Thanks @owonwo I took a look at your source code, and everything builds and runs cleanly locally.
Nice use of tailwinds and the abstraction into React components, I especially liked the use of fade
and a CSS style to enable/disable cards, and the hover interaction of the token amounts.
Some minor notes, in case you are interested in future bounties
master
branch of your forked repo, and create the PR relative to master
on this repo as well.build
directory, as this can be generated.Great work! I'll go ahead and complete the bounty on Gitcoin, and I'd like to tip you for such a quick turnaround.
If you'd like to give any feedback, I'm curious to know what it was like to work on the bounty so I can improve future tasks. Specifically:
how many hours did it take you total, if you counted? For the development period i spent:
what would have made it easier or more enjoyable to work on? The first was fine. The second lacked a prototype. So I guessed the flow. Otherwise, I would have planned the structure in a better way.
if you were to use the page yourself, what improvements to the design or usability would make it more clear to the user what's going on? Trying in some animations perhaps.
⚡️ A tip worth 0.65000 ETH (82.34 USD @ $126.68/ETH) has been granted to @owonwo for this issue from @cryptogoth. ⚡️
Nice work @owonwo! To redeem your tip, login to Gitcoin at https://gitcoin.co/explorer and select 'Claim Tip' from dropdown menu in the top right, or check your email for a link to the tip redemption page.
Issue Status: 1. Open 2. Started 3. Submitted 4. Done
This Bounty has been completed.
Additional Tips for this Bounty:
Thank you @owonwo it was a pleasure to see your work this time. I'll invite you to any related future bounties, and look forward to it again.
Background
Zero-knowledge assets are a way to transfer ownership of a private asset (the amount and participant addresses can be secret) on a public blockchain. In this case, Ethereum is the blockchain, and AZTEC is the zero-knowledge technology built on top of it. There are two kinds of assets on Ethereum: public tokens, called ERC20, and a newer, private kind, called ERC1724.
This project will be launched later in December 2019 as a web demo to let people interact first-hand with zero-knowledge assets in their browser. This will allow people to gain some intuition and experience with zero-knowledge assets.
This task is to implement a mockup from a previous issue #36 as a static page hosted on Netlify using React and
react-scripts
, using placeholder elements. User interactivity will be present to advance between the steps of the workflow, but blockchain interaction will be added in a separate, later issue.The mockup and interactions
Click through the following mockups to familiarize yourself with the process.
This interactive mockup (Mockup #1) contains the main look and interaction https://www.figma.com/file/eiVedZmhOLoHh4WAQgleTQ/Confidential-Transfer-Demo-Copy
Clicking the play button in upper-left corner will take you through the clickable interactive mockup.
and this one (Mockup #2) contains a third status column which includes a tx history. https://www.figma.com/file/KEV19jwlvgd3m9lexQx9KL/Confidential-Transfer-Demo?node-id=0%3A1
The following interactions should be handled in your implementation (slight differences from the mockups), starting with mockup 1
Technologies to use
within those constraints, any library you like can be used. Try to keep dependencies minimal and file sizes of the final build small.
How to work on this bounty:
Apply to work for this bounty on Gitcoin (for now) and send a short message mentioning bounties or other websites you've worked on that are React-based static sites hosted on Netlify or similar services.
Only a single submission and bounty payout will be issued, so timeliness and frequent communication are appreciated to get feedback and discuss ideas.
Fork this repo and use
react-scripts
to create a new Typescript package in the directorydemocracy/packages/zk-transfer-web
.When you're done with your implementation, deploy it to Netlify, with scripts that create a static build and then serve it (
react-scripts build
)Submit a pull request on github of your fork, and include a link to your netlify deployed site.
Ask questions, make suggestions, have fun
Check-ins on this github thread are appreciated to ask for feedback, make suggestions, or just share progress and celebrate successes.