0thElement
commented
1 year ago I've merged your korean translation. Thank you for the work!
Regarding your suggestions, I agree with most of them, however:
-
Regarding the default grid settings, I'd love to know the english translation of the message you included in the korean translation so that it'd be consistent between languages
-
About the permission error, it's already quite rare in the first place. Also if such an exception is thrown it'll properly show on the UI so I don't think it's necessary to handle the exception.
C0MATOS3
I know that a freshly made account coming out of nowhere and just opening a PR sounds extremely sketchy, but then again, after pulling a full-nighter on this one, I'm too tired to even care at this point I presume.
Here are also some points I found while translating and tampering with the project, which may or may not be useful:
Escaping Path String: If the path of a file contains escape sequences like \t, \n, \r, et cetera, the I18n.S() function will not escape the string, and print tabs/newlines/line breaks accordingly. This is quite likely if the user is running the application on Windows, and running Regex.Unescape() is strongly suggested.
Trying to delete the Base Timing Group: If the user tries to delete a timing group, the user will usually be prompted with a warning message. Will the user click "Yes", then the said group will be deleted. The only exception is when there is only 1 timing group remaining, which in that case the application will throw an exception. Just check if there are more than 1 timing groups at the moment, and we should be good to go.
Default Lua Grid Script: Added some more lines where you define a new color variable and use it. While some might consider such expressions basic, it would be worth noticing the user that they can do more than just draw yellow lines. Also, if you get the reference, you get the reference.
Compose.Exception.LoadProject: File.ReadAllText can also throw exceptions when the application does not have adequate access priviledges for the file. It may be good to mention that in the error message.