ArcticSnow / TopoPyScale

TopoPyScale: a Python library to perform simplistic climate downscaling at the hillslope scale
https://topopyscale.readthedocs.io
MIT License
39 stars 9 forks source link

Feature/overwrite existing (downscaled) files #54

Closed paswyss closed 1 year ago

paswyss commented 1 year ago

With this implementation, all downscaled files with the given filepattern (of the config file) get deleted prior to concatenating the downscaled products. So the parameter 'clean_outputs' can be set to false, but the files with the filepattern get overwritten. -> this has the advantage when e.g. once downscale spatial and once the points.

If wanted, an additional boolean config parameterr 'overwrite_output' could make sure, this is wanted.

The relevant changes are all between the lines 424 and 477. The res is just auto formation.

ArcticSnow commented 1 year ago

@paswyss , I took away all open_mfdataset() and to_mfdataset() and replace them with a concat. It seems this is where we have the conflict happening.

paswyss commented 1 year ago

@ArcticSnow Ah I see now, that you merged another branch. But the issue is still existing? So I will have a look and try to implement it there

paswyss commented 1 year ago

Should be good now. Please check again :) @ArcticSnow