search

ArcticSnow / TopoPyScale

TopoPyScale: a Python library to perform simplistic climate downscaling at the hillslope scale
https://topopyscale.readthedocs.io
MIT License
39 stars 9 forks source link

Not downscaling full time period #86

Closed paswyss closed 1 year ago

paswyss commented 1 year ago

When I downscale, I do not get the full period covered. So e.g. start = 01-10-2021 and end = 31-10-2022 I only have the downscaled product for the year 2022.

this is concerning all files -> e.g. for the ds_solar i get : ds_solar_Site_2022-01-01_2022-10-31.nc

ArcticSnow commented 1 year ago

This is strange. Is this a new behavior? In the past I had the opposite problem, where if the last month was not full it was discarded. I fixed it in commit I cannot find back. You may look at the line recently update by Joel in issue https://github.com/ArcticSnow/TopoPyScale/issues/73 . It may be a behavior of pandas datetime we do not explicitly request.

Also, it may be a good this to check if the behavior was present in prior commit, to make sure it wasn't introduced recently, or pinpoint when it was introduced.

paswyss commented 1 year ago

I found out, that this issue only occurs when split.IO=True So it has something to do with splitting and concatenating the time slices.

paswyss commented 1 year ago

Figured it out :) Works now.