search

ArcticZeroo / flutter-search-bar

(mostly) Automatic search-enabled appBar for flutter
BSD 3-Clause "New" or "Revised" License
266 stars 69 forks source link

No support for SliverAppBar #20

Closed IhorKlimov closed 6 years ago

IhorKlimov commented 6 years ago

SliverAppBar is currently not supported

ArcticZeroo commented 6 years ago

Sorry for late reply, never got this notification.

This should be a relatively simple change, the AppBar callback will just have to be less strict. Will do when I get a chance, or feel free to make a PR. Should just have to change the return type to StatefulWidget.

IhorKlimov commented 6 years ago

@ArcticZeroo Oh yeah, totally. It took me just a few mins. Just wanted to create an issue for it to point out

ArcticZeroo commented 6 years ago

Got it, thanks! Feel free to make that PR if you've already got it down :) otherwise I can pull it in tomorrow if you don't get a chance.

ArcticZeroo commented 6 years ago

Fixed in https://github.com/ArcticZeroo/flutter-search-bar/commit/0441e951228257ccbe284dc07ad85664487e0cda