search

ArcticZeroo / flutter-search-bar

(mostly) Automatic search-enabled appBar for flutter
BSD 3-Clause "New" or "Revised" License
266 stars 69 forks source link

Fix bad input field text color #36

Open cmaster11 opened 3 years ago

cmaster11 commented 3 years ago

Premise

Sorry for the mess of this PR, but the Android example was lacking the main activity file, so I recreated it with flutter create ., which in turn let to clearly more stuff being generated.

The re;evant altered code is in lib/src/flutter_search_bar_base.dart.

All of this has also been compiled/edited with Flutter 1.22.2

Bug

While trying to use the bar with a heavily dark customized theme (e.g. dark primary color and quite an amount of other edits), the input field was showing dark text, the cursor color was dark, and hint text was black.

Then, when I tried to use the bare Android example, that was having the same issue too.

I think that, inbetween Flutter version changes, the input field is not behaving like you originally planned it to.

The fix here is to use some default values, which work correctly on a standard dark theme, but also work correctly if a custom one is passed.

ArcticZeroo commented 3 years ago

Also, could you squash 29e62d0 (#36) and abb1395 (#36) together at some point?

cmaster11 commented 3 years ago

Also, could you squash 29e62d0 (#36) and abb1395 (#36) together at some point?

I wonder if it would be cleaner to just squash the whole PR, there is quite the amount of commits here

ArcticZeroo commented 3 years ago

I wonder if it would be cleaner to just squash the whole PR, there is quite the amount of commits here

I think it may be cleaner to squash everything after the first commit together instead, so that there isn't just one commit that adds the reformatted example app + everything else. But either way is fine with me

18601673727 commented 2 years ago

any update on this?