search

ArcticaProject / arctica-greeter

Arctica Greeter: Greeter Frontend for LightDM
GNU General Public License v3.0
27 stars 8 forks source link

GreeterList: Fix check for LightDM.PromptType.SECRET, let screen read… #74

Closed sunweaver closed 1 year ago

sunweaver commented 1 year ago

…er read "Enter username" instead of "Enter password for <user>".

Fixes: https://github.com/ArcticaProject/arctica-greeter/issues/72

Ionic commented 1 year ago

I'll work on this next week, but a cursory glance tells me that something must be missing in this PR. The only change in here doesn't make sense - the code should be functionally equivalent. Especially so, since vala doesn't have a feature that would convert other types implicitly to boolean, so if the code was accepted before, checking against true should change exactly nothing.

sunweaver commented 1 year ago

Yeah, you are right, this one smells fishy. Not sure what drove me. Indeed, with the above changed, orca started reading the correct phrase. However, it now also reads the correct phrase without this change.

Closing for now... Need to revisit this.