ArcticaProject / arctica-greeter

Arctica Greeter: Greeter Frontend for LightDM
GNU General Public License v3.0
27 stars 10 forks source link

Show labels for 'Username:' and 'Password:' if configured via gsettings. #76

Closed sunweaver closed 9 months ago

sunweaver commented 9 months ago

I'm generally fine with this PR and will only change it very slightly while merging, but are you sure that you only want Username: and Password: prompts to be shown as messages? On forced password changes, for example, prompts will read like "Current password:" and the like, but given that they don't match the pre-defined prompts here, they'll only be shown in the input prompt. Wouldn't it make sense to show all prompts as a message? I'm aware that we can't translate others, while it's easy to do so for the other two types, but it's not like we wouldn't pass prompts to the user - just not via messages.

There is a whole bunch not-so-often appearing places where this needs to be adjusted, as well. Please let's have this minimal change for now. This needs more work / time.