search

ArcticaProject / arctica-greeter

Arctica Greeter: Greeter Frontend for LightDM
GNU General Public License v3.0
27 stars 10 forks source link

Move NM_APPLET_HIDE_POLICY_ITEMS env var setting above OptionContext … #83

Closed sunweaver closed 9 months ago

sunweaver commented 9 months ago

…parsing.

While working on font-scaling support and fixing HiDPI support, I discovered, that GLib.Environment.set_variable() does not take effect after OptionContext.parse() has been called. (For whatever unknown reason...).

To mitigate this, let's move all env variable setups to the code portion above the c.parse() call.

Ionic commented 9 months ago

This feels very weird... and it makes me wonder if greeter_set_env actually has an effect (other than adding variables to the DBUS activation environment)? The menubar makes some use of this and is certainly created after the program options have been parsed, so we might want to... fix the underlying bug instead?

sunweaver commented 9 months ago

This feels very weird... and it makes me wonder if greeter_set_env actually has an effect (other than adding variables to the DBUS activation environment)? The menubar makes some use of this and is certainly created after the program options have been parsed, so we might want to... fix the underlying bug instead?

Yes, possibly as a follow-up.

Also greeter_set_env might not be the right approach anymore as the indicators are not launched via systemd anymore. They are now simple child processes of arctica-greeter.

Thus, greeter_set_env might simply be dropped, now that I think of it another time. And the variable settings for indicator could then be moved above the OptionContext parse() call.

And yes, it would be good to track down the underlying issue, but this needs to be done another time, as it is not in the scope of the current customer project. Please add an issue for this for now. Thanks.