search

ArcticaProject / arctica-greeter

Arctica Greeter: Greeter Frontend for LightDM
GNU General Public License v3.0
27 stars 10 forks source link

src/arctica-greeter.vala: Move HiDPI setup above OptionContext parsing. #84

Closed sunweaver closed 9 months ago

sunweaver commented 9 months ago

This depends on PR #83

sunweaver commented 9 months ago

Hi Mihai,

I'd like to rework this PR a bit, to at least add some kind of error handling in case arctica-greeter-check-hidpi returns garbage. Will change, force-push and let you have a look at the new code.

Please send this improvement as a follow-up PR. Good point, go ahead (but not as part of this PR, please).

I also don't really like the integer scaling factor. Currently, it's either 1 or 2, but HiDPI support often uses other scaling factors like 125 %, 150 % etc., so I'd rather use values ranging from 100 to 200. Neither AG itself, nor the python script, nor GTK are equipped for this, but I realize that that's something that we can work on at a later time. GTK only supporting full integer scaling is probably the worst issue here, and might even make further work in vain.

Please leave this as is for now. We can't GTK-3's integer scaling for now. I indeed thought about using an int value instead of hidpi enable/disable. But, I'd like to rethink this a little more. So, please don't. Thanks.

Lastly, this PR also applies the scaling in test mode, which was explicitly excluded before. I'm not sure if it's good to enable HiDPI detection in test mode by default. Maybe we should add a switch that enables it and keep it disabled by defaultlike it was previously?

Nope, this was changed intentionally. So, people can test the scaling locally in their user session. The unit tests are entirely broken these days anyway, so whenever we get back to fixing them, we can adjust tests to whatever we put into the test-mode...