While working on font-scaling support and fixing HiDPI support, I discovered, that GLib.Environment.set_variable() does not take effect after OptionContext.parse() has been called. (For whatever unknown reason...).
To mitigate this, let's move all env variable setups to the code portion above the c.parse() call.
While the PR works around the issue for the NM applet, code in src/menubar.vala still sets a set of environment variables and is certainly created after the program arguments have been processed.
While the environment variable changes might not be that critical any longer since we stopped spawning indicators via systemd and switched to spawning them as subprocesses of the greeter, and the dbus activation environment may likewise not be needed any longer, they probably still need data such as the unique dbus name.
This is probably something that should be dbused debugged and fixed in the long run.
From #83:
While the PR works around the issue for the NM applet, code in
src/menubar.valastill sets a set of environment variables and is certainly created after the program arguments have been processed.While the environment variable changes might not be that critical any longer since we stopped spawning indicators via systemd and switched to spawning them as subprocesses of the greeter, and the dbus activation environment may likewise not be needed any longer, they probably still need data such as the unique dbus name.
This is probably something that should be
dbuseddebugged and fixed in the long run.