search

ArcticaProject / nx-libs

nx-libs
Other
120 stars 39 forks source link

Support Cygwin64 #1008

Closed vatral closed 3 years ago

vatral commented 3 years ago

Hello! I've been getting things up to date here, and thought I'd do a 64 bit build of recent code.

It turns out that 64 bit Cygwin defines __CYGWIN__ instead of __CYGWIN32__, but other than that things seem to be working okay in my testing so far.

sunweaver commented 3 years ago

Waiting for the new Github Actions CI. If CI succeeds, I will merge.

uli42 commented 3 years ago

I am wondering if checking for __CYGWIN alone would be sufficient, without distinguishing betweeen 32 and 64 bit.

On Mon, Jun 7, 2021 at 8:15 PM Mike Gabriel @.***> wrote:

@.**** approved this pull request.

@vatral https://github.com/vatral: Thanks for this. LGTM. Hope you are doing well!

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/ArcticaProject/nx-libs/pull/1008#pullrequestreview-677743036, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABQHBZC3BPFJ4RBATMJIZH3TRUED3ANCNFSM4Y4WUQYQ .

vatral commented 3 years ago

@sunweaver Thank you!

@uli42 Possibly. It's been a while since then, but I recall having some reason for doing it that way, though I don't remember what. Either it didn't work, or I didn't know when exactly __CYGWIN__ was introduced and decided to be careful about it. Googling suggests __CYGWIN__ should work and is an old addition: http://www.cygwin.com/faq/faq.html#faq.programming.64bitporting-cygwin64

So hmm... it would make sense to test just to make sure.