Pr/many clipboard fixes

[uli42]

The result of many, many hours of testing and debugging the clipboard code.

With this you can now copy/paste anything (as long as it is smaller than 256kb), e.g. images or rich text.

[sunweaver]

@uli42: Once you are done, please re-request review, maybe ideally send me an email, so that I don't miss it. Thanks.

[uli42]

I am almost done, will push probably tomorrow

On Fri, Jun 11, 2021 at 11:18 AM Mike Gabriel @.***> wrote:

@uli42: Once you are done, please re-request review, maybe ideally send me an email, so that I don't miss it. Thanks.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

[sunweaver]

@uli42: just checking what the status of this PR re-write is. Let me know when/if I should take a look.

[uli42]

Well, as always when I look at the code I found a bug and I immediately started working on it. I think I have fixed it now. Will (hopefully) push it later today.

On Sun, Jun 20, 2021 at 12:40 PM Mike Gabriel @.***> wrote:

@uli42: just checking what the status of this PR re-write is. Let me know when/if I should take a look.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

[uli42]

I think the code can be merged like this, please review again!

[uli42]

Iirc these two spaces are used to store some remote atoms. Just grep for the array name and you will see

Uli

Vadim Troshchinskiy @.***> schrieb am Do., 26. Aug. 2021, 15:03:

@.**** commented on this pull request.

Long time no see!

We've got an interest in this PR, so I've been checking it out. So far I noticed a minor oddity that is probably harmless, but I thought I'd point it out just in case.

In nx-X11/programs/Xserver/hw/nxagent/Atoms.c https://github.com/ArcticaProject/nx-libs/pull/1018#discussion_r696113426 :

@@ -76,7 +76,7 @@ Atom nxagentAtoms[NXAGENT_NUMBER_OF_ATOMS];

• Careful! Do not change indices here! Some of those are referenced
• at other places via nxagentAtoms[index]. / -static char nxagentAtomNames[NXAGENT_NUMBER_OF_ATOMS + 1] = +static char *nxagentAtomNames[NXAGENT_NUMBER_OF_ATOMS + 2] =

Where does the +2 come from?

I see that there's two NULLs at the bottom, but this would seem the sort of thing that would merit an explanatory comment. A single NULL makes sense as a list terminator, but why the second one? Though I'm not seeing any place that looks for a NULL in this array.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ArcticaProject/nx-libs/pull/1018#pullrequestreview-738830202, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABQHBZB4ZGYOR2UQPFZWXBDT6Y3THANCNFSM46M23PKA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email .

[uli42]

@sunweaver ping

[uli42]

Great! Thanks a lot!

Mike Gabriel @.***> schrieb am Mo., 18. Okt. 2021, 09:29:

Merged #1018 https://github.com/ArcticaProject/nx-libs/pull/1018 into 3.6.x.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ArcticaProject/nx-libs/pull/1018#event-5476192783, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABQHBZCFPKS4QTS66T76FBTUHPEGDANCNFSM46M23PKA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.