search

ArcticaProject / nx-libs

nx-libs
Other
120 stars 39 forks source link

clipboard: don't allow -clipboard command line option to be overridden from client-side (via nx/nx options) #1020

Open sunweaver opened 2 years ago

sunweaver commented 2 years ago

This is a reminder bug for me to investigate this closer after the massive clipboard PR (#1018 ) has been merged.

We should not support override the -clipboard cmd line option via nx/nx options. If we do, we need to discuss this.

Either, -clipboard has precendence over the nx/nx clipboard option, which means the server admin can overrule the client options entirely.

Or, we add another cmdline option to nxagent, e.g. -clipboard-force-server-setting (bad option name, but explaing what it should do).

This related to https://bugs.x2go.org/1552 and should be addressed outside of X2Go Server (i.e. in nx-libs and x2gokdrive Xserver).

sunweaver commented 2 years ago

However, another corner case is an open nxagent / X2Go Server regarding the clipboard (i.e. clipboard=both), but a client that does not want to leak client-side clipboard information into the nxagent / X2Go session. This should also be considered when checking the above.

uli42 commented 2 years ago

We also need to consider that the user can access the options file and manipulate it on its own and then issue a reconnect. So if this should be a security feature some more thinking is required to make that bulletproof.

Maybe add a server side configuration that specifies what settings to ignore on reconnect.

On Mon, Aug 2, 2021 at 8:58 AM Mike Gabriel @.***> wrote:

However, another corner case is an open nxagent / X2Go Server regarding the clipboard (i.e. clipboard=both), but a client that does not want to leak client-side clipboard information into the nxagent / X2Go session. This should also be considered when checking the above.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or unsubscribe.