uli42
commented
2 years ago The code is the same as in upstream libX11 (https://gitlab.freedesktop.org/xorg/lib/libx11/-/blob/master/src/xkb/XKBBind.c#L226) so upstream should also throw an error in that constellation.
Where's this old version used?
Of course I have no problem adding that...
On Mon, Jan 31, 2022 at 2:48 PM Simon Matter @.***> wrote:
Hi,
On certain older GCC versions I see build failures with this error:
XKBBind.c: In function 'XLookupKeysym': XKBBind.c:244: error: #pragma GCC diagnostic not allowed inside functions XKBBind.c:245: error: #pragma GCC diagnostic not allowed inside functions XKBBind.c:251: error: #pragma GCC diagnostic not allowed inside functions
I saw GCC version detection in nx-libs-3.5.99.26/nx-X11/lib/include/X11/Xlibint.h so I guess it should be acceptable to add here as well. May I ask for the change below after #1037 so that builds with affected GCC doesn't fail.
Thanks, Simon
--- nx-libs-3.5.99.26/nx-X11/lib/src/xkb/XKBBind.c.orig 2022-01-31 10:56:51.000000000 +0100 +++ nx-libs-3.5.99.26/nx-X11/lib/src/xkb/XKBBind.c 2022-01-31 10:57:58.000000000 +0100 @@ -240,14 +240,14 @@ XLookupKeysym(register XKeyEvent * event
ifdef clang
pragma clang diagnostic push
pragma clang diagnostic ignored "-Wdeprecated-declarations"
-#elif defined(GNUC) +#elif defined(GNUC) && ((GNUC 100 + __GNUC_MINOR__) >= 405) / 4.5+ */
pragma GCC diagnostic push
pragma GCC diagnostic ignored "-Wdeprecated-declarations"
endif
return XKeycodeToKeysym(dpy, event->keycode, col);ifdef clang
pragma clang diagnostic pop
-#elif defined(GNUC) +#elif defined(GNUC) && ((GNUC 100 + __GNUC_MINOR__) >= 405) / 4.5+ */
pragma GCC diagnostic pop
endif
— Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android. You are receiving this because you authored the thread.Message ID: @.***>
realsimix
joakim-tjernlund
sunweaver
Hi,
On certain older GCC versions I see build failures with this error:
I saw GCC version detection in nx-libs-3.5.99.26/nx-X11/lib/include/X11/Xlibint.h so I guess it should be acceptable to add here as well. May I ask for the change below after #1037 so that builds with affected GCC doesn't fail.
Thanks, Simon