ArcticaProject / nx-libs

nx-libs
Other
119 stars 39 forks source link

nxagent: add keystrokes to switch clipboard mode on the fly #1047

Open xavierog opened 2 years ago

xavierog commented 2 years ago

This pull request adds nxagent keystrokes to switch clipboard mode on the fly. A typical use case for this feature is to prevent access to the real X server's clipboard most of the time, except for a couple seconds when this actually proves necessary. Otherly put, it simply makes nxagent's"clipboard mode" feature more flexible. Should it prove unnecessary or harmful to some users, the whole thing can be disabled by reconfiguring keystrokes.

uli42 commented 1 year ago

I am sorry that you did not get a reaction to this so far - I just detected it today and will have a look at it

sunweaver commented 1 year ago

@xavierog Can you please give feedback on the questions asks in the code review of this PR? Thanks.

@uli42 I @xavierog will not respond, I think the idea of being able to switch between clipboard modes is basically great, but we should add yet another option that enables/disables this feature server-side/client-side. Disabled clipboard (by admin / by client user) is a feature and we would undermine it here. What do you think?

sunweaver commented 1 year ago

@uli42 I forgot to finish my sentence above. What you be willing to finalize this PR if there is not feedback from @xavierog?

xavierog commented 1 year ago

Hi! Indeed, this PR is getting close to being one year old. In practice, I am not dead, just super busy. Good news, it should get better very soon, and I should be able to dive again in this patch, answer the questions and apply the suggestions above.

sunweaver commented 1 year ago

@xavierog This is awesome to hear!!!

uli42 commented 1 week ago

I agree that it is a nice feature. We could even extend it to a mode where only one clipboard action is allowed (pasting once) and afterwards it is disabled again. This way you get a bit more security.