search

ArcticaProject / nx-libs

nx-libs
Other
120 stars 39 forks source link

Many unused files during build #256

Open uli42 opened 7 years ago

uli42 commented 7 years ago

The list below contains a number of files that have not been read during build on Ubuntu 14.04 (files that had not change their access time). I have commented on most of the files. For some of the files I have prepared a PR (pr/unused_files). Please have a look at it and comment.

  1. removed in my branch uli42:pr/unused files
  2. can generate initatoms.c and Xatom.h but these files are in the repo already
  3. shouldn't this come with autotools?
  4. required for Windows build, I think
  5. are only included when XKBSRV_NEED_FILE_FUNCS is set - which we do not
  6. drop completely?
  7. are dropped upstream, I am working on that
  8. what are those *-def.cpp files needed for?
  9. are these helper scripts still required?
  10. Keysyms for Apollo?
  11. have not found any reference for that file
  12. only used if compiling with TEST
  13. should be removed, along with all the #ifdef __UNIXOS2__ and AIX stuff
  14. maybe a missing makefile entry (missed while backporting?)
  15. see #255
./nxcompshad:
-rwxrwxr-x 1 uli uli   4773 Okt 29 21:27 install-sh        3)
-rw-rw-r-- 1 uli uli   6989 Okt 29 21:27 Win.h             4)

./nxcompext:
-rwxrwxr-x 1 uli uli   4773 Okt 29 21:27 install-sh        3)
-rwxrwxr-x 1 uli uli    702 Okt 29 21:27 mkinstalldirs     3)
-rw-rw-r-- 1 uli uli   2002 Okt 29 21:27 NXlibint.h       15)

./nxproxy:
-rwxrwxr-x 1 uli uli   4773 Okt 29 21:27 install-sh        3)
-rwxrwxr-x 1 uli uli    702 Okt 29 21:27 mkinstalldirs     3)

./nxcomp:
-rwxrwxr-x 1 uli uli    4773 Okt 29 21:27 install-sh       3)
-rwxrwxr-x 1 uli uli     702 Okt 29 21:27 mkinstalldirs    3)
-rw-rw-r-- 1 uli uli    2052 Okt 29 21:27 Utils.cpp        1)

./nx-X11:
-rw-rw-r-- 1 uli uli 39928 Okt 29 21:27 registry

./nx-X11/include:
-rw-rw-r-- 1 uli uli   2298 Okt 29 21:27 ap_keysym.h       10)
-rw-rw-r-- 1 uli uli   1778 Okt 29 21:27 Xw32defs.h        4)
-rw-rw-r-- 1 uli uli   2156 Okt 29 21:27 Xwindows.h        4)
-rw-rw-r-- 1 uli uli   1881 Okt 29 21:27 Xwinsock.h        4)
-rw-rw-r-- 1 uli uli   3971 Okt 29 21:27 XWDFile.h         4)

./nx-X11/include/GL:
-rw-rw-r-- 1 uli uli 15907 Okt 29 21:27 glu.h

./nx-X11/include/extensions:
-rw-rw-r-- 1 uli uli  5487 Okt 29 21:27 vldXvMC.h
-rw-rw-r-- 1 uli uli  1962 Okt 29 21:27 saver.h
-rw-rw-r-- 1 uli uli  5130 Okt 29 21:27 saverproto.h
-rw-rw-r-- 1 uli uli  4217 Okt 29 21:27 scrnsaver.h
-rw-rw-r-- 1 uli uli 10220 Okt 29 21:27 Xvlib.h
-rw-rw-r-- 1 uli uli  4377 Okt 29 21:27 XvMClib.h
-rw-rw-r-- 1 uli uli  5126 Okt 29 21:27 XKBrules.h         5)
-rw-rw-r-- 1 uli uli 11174 Okt 29 21:27 XKBfile.h          5)
-rw-rw-r-- 1 uli uli 30853 Okt 29 21:27 XInput.h

./nx-X11/programs/Xserver:
-rwxrwxr-x 1 uli uli     1088 Okt 29 21:27 fix-miregion     9)
-rwxrwxr-x 1 uli uli      471 Okt 29 21:27 fix-miregion-private 9)
-rwxrwxr-x 1 uli uli     1905 Okt 29 21:27 fix-region       9)

./nx-X11/programs/Xserver/record:
-rw-rw-r-- 1 uli uli    807 Okt 29 21:27 recordmod.c        1)

./nx-X11/programs/Xserver/record/module:
-rw-rw-r-- 1 uli uli 870 Okt 29 21:27 Imakefile             1)

./nx-X11/programs/Xserver/dbe:
-rw-rw-r-- 1 uli uli    803 Okt 29 21:27 dbemodule.c        1)

./nx-X11/programs/Xserver/dbe/module:
-rw-rw-r-- 1 uli uli 871 Okt 29 21:27 Imakefile             1)

./nx-X11/programs/Xserver/GL:
-rw-rw-r--  1 uli uli   35755 Okt 29 21:27 glxmodule.c      1)

./nx-X11/programs/Xserver/GL/glx:
-rw-rw-r-- 1 uli uli   14678 Okt 29 21:27 glx-def.cpp       8) 

./nx-X11/programs/Xserver/GL/mesa/GLcore:
-rw-rw-r-- 1 uli uli    26859 Okt 29 21:27 GLcore-def.cpp
-rw-rw-r-- 1 uli uli     2020 Okt 29 21:27 GLcoremodule.c   1)

./nx-X11/programs/Xserver/randr:
-rw-rw-r-- 1 uli uli    1985 Okt 29 21:27 registry.h

./nx-X11/programs/Xserver/fb:
-rw-rw-r-- 1 uli uli    1875 Okt 29 21:27 fbmodule.c        1)
-rw-rw-r-- 1 uli uli    1689 Okt 29 21:27 fb24_32.h

./nx-X11/programs/Xserver/fb/module:
-rw-rw-r-- 1 uli uli 167 Okt 29 21:27 Imakefile             1)

./nx-X11/programs/Xserver/dix:
-rw-rw-r-- 1 uli uli    1237 Okt 29 21:27 ffs.c             1)
-rw-rw-r-- 1 uli uli    1234 Okt 29 21:27 buildatoms        2)

./nx-X11/programs/Xserver/Xext:
-rw-rw-r-- 1 uli uli     437 Okt 29 21:27 xvmod.c           1)
-rw-rw-r-- 1 uli uli     309 Okt 29 21:27 xvmodproc.h       1) 
-rw-rw-r-- 1 uli uli    2358 Okt 29 21:27 xtest1.frags
-rw-rw-r-- 1 uli uli    1699 Okt 29 21:27 dpmsstubs.c
-rw-rw-r-- 1 uli uli   34741 Okt 29 21:27 saver.c

./nx-X11/programs/Xserver/Xext/extmod:
-rw-rw-r-- 1 uli uli 1716 Okt 29 21:27 Imakefile            1)
-rw-rw-r-- 1 uli uli 3563 Okt 29 21:27 modinit.c            1)

./nx-X11/programs/Xserver/include:
-rw-rw-r-- 1 uli uli  2393 Okt 29 21:27 rgb.h

./nx-X11/programs/Xserver/hw/nxagent:
-rw-rw-r-- 1 uli uli   14633 Okt 29 21:27 os2Stub.c         13)
-rw-rw-r-- 1 uli uli   53156 Okt 29 21:27 screensaver       11) 
-rw-rw-r-- 1 uli uli    5446 Okt 29 21:27 Literals.h        12)

./nx-X11/lib/X11:
-rw-rw-r-- 1 uli uli    13877 Okt 29 21:27 os2Stubs.c       13)
-rw-rw-r-- 1 uli uli    80426 Okt 29 21:27 jump_funcs
-rw-rw-r-- 1 uli uli     3594 Okt 29 21:27 jump_ignore
-rw-rw-r-- 1 uli uli     4570 Okt 29 21:27 jump_vars
-rw-rw-r-- 1 uli uli     2317 Okt 29 21:27 lcDynamic.c      14)
-rw-rw-r-- 1 uli uli     3595 Okt 29 21:27 XlcSL.c          14)
-rw-rw-r-- 1 uli uli     1814 Okt 29 21:27 Xaixlcint.h      13)
-rw-rw-r-- 1 uli uli    15503 Okt 29 21:27 XlcDL.c          14)
-rw-rw-r-- 1 uli uli     6343 Okt 29 21:27 UIThrStubs.c     14)
-rw-rw-r-- 1 uli uli    40125 Okt 29 21:27 X11-def.cpp       8) 
-rw-rw-r-- 1 uli uli    11611 Okt 29 21:27 XDefaultIMIF.c   14)
-rw-rw-r-- 1 uli uli    26909 Okt 29 21:27 XDefaultOMIF.c   14)

./nx-X11/lib/X11/lcUniConv:
-rw-rw-r-- 1 uli uli  31002 Okt 29 21:27 cjk_tab_to_h.c     14)
-rw-rw-r-- 1 uli uli  16887 Okt 29 21:27 8bit_tab_to_h.c    14)
-rw-rw-r-- 1 uli uli    358 Okt 29 21:27 ascii.h            14)

./nx-X11/lib/X11/util:
-rw-rw-r-- 1 uli uli  246 Okt 29 21:27 mkks.sh

./nx-X11/lib/X11/xlibi18n:                                    
-rw-rw-r-- 1 uli uli  234 Okt 29 21:27 Imakefile             6)
-rw-rw-r-- 1 uli uli 3132 Okt 29 21:27 Xi18nLib.conf         6)

./nx-X11/lib/X11/xlibi18n/im:
-rw-rw-r-- 1 uli uli 296 Okt 29 21:27 Imakefile              6)

./nx-X11/lib/X11/xlibi18n/im/ximcp:
-rw-rw-r-- 1 uli uli 1767 Okt 29 21:27 Imakefile             6)
-rw-rw-r-- 1 uli uli   41 Okt 29 21:27 Ximcp.mapfile         6)

./nx-X11/lib/X11/xlibi18n/lc:
-rw-rw-r-- 1 uli uli 303 Okt 29 21:27 Imakefile              6)

./nx-X11/lib/X11/xlibi18n/lc/def:
-rw-rw-r-- 1 uli uli 256 Okt 29 21:27 Imakefile              6) 
-rw-rw-r-- 1 uli uli  48 Okt 29 21:27 Xlc.mapfile            6)

./nx-X11/lib/X11/xlibi18n/lc/gen:
-rw-rw-r-- 1 uli uli 260 Okt 29 21:27 Imakefile              6)
-rw-rw-r-- 1 uli uli  48 Okt 29 21:27 Xlc.mapfile            6)

./nx-X11/lib/X11/xlibi18n/lc/Utf8:
-rw-rw-r-- 1 uli uli 265 Okt 29 21:27 Imakefile              6)

./nx-X11/lib/X11/xlibi18n/om:
-rw-rw-r-- 1 uli uli 298 Okt 29 21:27 Imakefile              6)

./nx-X11/lib/X11/xlibi18n/om/generic:
-rw-rw-r-- 1 uli uli 577 Okt 29 21:27 Imakefile              6)
-rw-rw-r-- 1 uli uli  48 Okt 29 21:27 Xom.mapfile            6)

./nx-X11/lib/xtrans:
-rw-rw-r-- 1 uli uli 33194 Okt 29 21:27 Xtranstli.c          7) 
-rw-rw-r-- 1 uli uli 62486 Okt 29 21:27 Xtranslcl.c          7)
-rw-rw-r-- 1 uli uli 26678 Okt 29 21:27 Xtransos2.c          7)
-rw-rw-r-- 1 uli uli 14598 Okt 29 21:27 Xtransdnet.c         7) 

./nx-X11/config/cf:
-rw-rw-r-- 1 uli uli   1265 Okt 29 21:27 cross.def
-rw-rw-r-- 1 uli uli   5004 Okt 29 21:27 cross.rules
-rw-rw-r-- 1 uli uli  23935 Okt 29 21:27 README
-rw-rw-r-- 1 uli uli   3964 Okt 29 21:27 ServerLib.tmpl

./nx-X11/extras/Mesa/src/mesa/shader/slang:
-rw-rw-r-- 1 uli uli  4154 Okt 29 21:27 traverse_wrap.h

./nx-X11/extras/Mesa/src/mesa/shader/slang/library:
-rw-rw-r-- 1 uli uli  3658 Okt 29 21:27 slang_vertex_builtin_gc.h
-rw-rw-r-- 1 uli uli 48980 Okt 29 21:27 slang_core_gc_bin.h
-rw-rw-r-- 1 uli uli  4276 Okt 29 21:27 slang_fragment_builtin_gc.h
-rw-rw-r-- 1 uli uli 31197 Okt 29 21:27 slang_common_builtin_gc.h

./nx-X11/extras/Mesa/src/mesa/tnl:
-rw-rw-r-- 1 uli uli 13695 Okt 29 21:27 t_vtx_x86.c
-rw-rw-r-- 1 uli uli 17922 Okt 29 21:27 t_vtx_x86_gcc.S

./nx-X11/extras/Mesa/src/mesa/swrast:
-rw-rw-r-- 1 uli uli   1239 Okt 29 21:27 s_trispan.h
-rw-rw-r-- 1 uli uli   7140 Okt 29 21:27 s_spantemp.h

./nx-X11/extras/Mesa/include/GL:
-rw-rw-r-- 1 uli uli   8455 Okt 29 21:27 osmesa.h
sunweaver commented 7 years ago

On So 30 Okt 2016 02:08:29 CET, Ulrich Sibiller wrote:

The list below contains a number of files that have not been read
during build on Ubuntu 14.04 (files that had not change their access
time). I have commented on most of the files. For some of the files
I have prepared a PR (pr/unused_files). Please have a look at it and
comment.

  1. removed in my branch uli42:pr/unused files
  2. can generate initatoms.c and Xatom.h but these files are in
    the repo already
  3. shouldn't this come with autotools?
  4. required for Windows build, I think
  5. are only included when XKBSRV_NEED_FILE_FUNCS is set - which we do not
  6. drop completely?
  7. are dropped upstream, I am working on that
  8. what are those *-def.cpp files needed for?
  9. are these helper scripts still required?
  10. Keysyms for Apollo?
  11. have not found any reference for that file
  12. only used if compiling with TEST
  13. should be removed, along with all the #ifdef __UNIXOS2__ and
    AIX stuff
  14. maybe a missing makefile entry (missed while backporting?)
  15. see #255
> ./nxcompshad:
> -rwxrwxr-x 1 uli uli   4773 Okt 29 21:27 install-sh        3)

install-sh can go away, in theory...

> -rw-rw-r-- 1 uli uli   6989 Okt 29 21:27 Win.h             4)

The winbuild of nx-X11 and a like is really non-maintained and to my
sense we should really think about dropping that support. If someone
steps out and seriously wants to continue / reintroduce Windows
maintenance, this file can be re-added. But for now, we should drop
it, IMHO. And with it, the Cygwin32 support for everything except
nxcomp and nxproxy.

> ./nxcompext:
> -rwxrwxr-x 1 uli uli   4773 Okt 29 21:27 install-sh        3)

can go away...

> -rwxrwxr-x 1 uli uli    702 Okt 29 21:27 mkinstalldirs     3)

dito...

> -rw-rw-r-- 1 uli uli   2002 Okt 29 21:27 NXlibint.h       15)

See PR#258.

> ./nxproxy:
> -rwxrwxr-x 1 uli uli   4773 Okt 29 21:27 install-sh        3)
> -rwxrwxr-x 1 uli uli    702 Okt 29 21:27 mkinstalldirs     3)

can both go away...

> ./nxcomp:
> -rwxrwxr-x 1 uli uli    4773 Okt 29 21:27 install-sh       3)
> -rwxrwxr-x 1 uli uli     702 Okt 29 21:27 mkinstalldirs    3)

can go away...

> -rw-rw-r-- 1 uli uli    2052 Okt 29 21:27 Utils.cpp        1)

Ahaaa... Let me check... Yeah. Can go away.

> ./nx-X11:
> -rw-rw-r-- 1 uli uli 39928 Okt 29 21:27 registry

Drop it. This is not ours and probably still available at X.org.

> ./nx-X11/include:
> -rw-rw-r-- 1 uli uli   2298 Okt 29 21:27 ap_keysym.h       10)

Well... Not supported by us, not available hardware anymore, possibly.
Drop it.

> -rw-rw-r-- 1 uli uli   1778 Okt 29 21:27 Xw32defs.h        4)
> -rw-rw-r-- 1 uli uli   2156 Okt 29 21:27 Xwindows.h        4)
> -rw-rw-r-- 1 uli uli   1881 Okt 29 21:27 Xwinsock.h        4)
> -rw-rw-r-- 1 uli uli   3971 Okt 29 21:27 XWDFile.h         4)

See above. Let's discontinue Win32/Cygwin support for nxagent.

> ./nx-X11/include/GL:
> -rw-rw-r-- 1 uli uli 15907 Okt 29 21:27 glu.h

Not referenced elsewhere in the code. It can be dropped.

> ./nx-X11/include/extensions:
> -rw-rw-r-- 1 uli uli  5487 Okt 29 21:27 vldXvMC.h
> -rw-rw-r-- 1 uli uli  1962 Okt 29 21:27 saver.h
> -rw-rw-r-- 1 uli uli  5130 Okt 29 21:27 saverproto.h
> -rw-rw-r-- 1 uli uli  4217 Okt 29 21:27 scrnsaver.h
> -rw-rw-r-- 1 uli uli 10220 Okt 29 21:27 Xvlib.h
> -rw-rw-r-- 1 uli uli  4377 Okt 29 21:27 XvMClib.h

This is strange. We build those extensions for nxagent. I just checked
for Xserver/Xext/saver.c (which includes saver.h). Sometimes, we use
<nx-X11/extensions/> as include statement and sometimes we
use "". May it be that you built on a non-clean chroot?

If you build locally, at least remove/purge all nx related .deb
packages from your system. My impression is that those files got used,
but from the system installation rather than from your local copy of
code.

> -rw-rw-r-- 1 uli uli  5126 Okt 29 21:27 XKBrules.h         5)
> -rw-rw-r-- 1 uli uli 11174 Okt 29 21:27 XKBfile.h          5)

Then (reason given in 5) ) we can drop them IMHO.

> -rw-rw-r-- 1 uli uli 30853 Okt 29 21:27 XInput.h

Same as written above about saver.h & co.

> ./nx-X11/programs/Xserver:
> -rwxrwxr-x 1 uli uli     1088 Okt 29 21:27 fix-miregion     9)
> -rwxrwxr-x 1 uli uli      471 Okt 29 21:27 fix-miregion-private 9)
> -rwxrwxr-x 1 uli uli     1905 Okt 29 21:27 fix-region       9)

I added these more for the purpose of documentation. (Like X.org did,
too). Basically, they can go away.

> ./nx-X11/programs/Xserver/record:
> -rw-rw-r-- 1 uli uli    807 Okt 29 21:27 recordmod.c        1)

We don't build a loadable nxagent, so the complete DoLoadableXserver
logic can be dropped from our build approach.

> ./nx-X11/programs/Xserver/record/module:
> -rw-rw-r-- 1 uli uli 870 Okt 29 21:27 Imakefile             1)

Ok.

> ./nx-X11/programs/Xserver/dbe:
> -rw-rw-r-- 1 uli uli    803 Okt 29 21:27 dbemodule.c        1)

Ok.

> ./nx-X11/programs/Xserver/dbe/module:
> -rw-rw-r-- 1 uli uli 871 Okt 29 21:27 Imakefile             1)

Ok.

> ./nx-X11/programs/Xserver/GL:
> -rw-rw-r--  1 uli uli   35755 Okt 29 21:27 glxmodule.c      1)

Ok.

> ./nx-X11/programs/Xserver/GL/glx:
> -rw-rw-r-- 1 uli uli   14678 Okt 29 21:27 glx-def.cpp       8)

all *-def.cpp files can be removed IMHO. This should be done in one commit.

> ./nx-X11/programs/Xserver/GL/mesa/GLcore:
> -rw-rw-r-- 1 uli uli    26859 Okt 29 21:27 GLcore-def.cpp   8)  
> [added by @sunweaver]
> -rw-rw-r-- 1 uli uli     2020 Okt 29 21:27 GLcoremodule.c   1)

Ok.

> ./nx-X11/programs/Xserver/randr:
> -rw-rw-r-- 1 uli uli    1985 Okt 29 21:27 registry.h

This file came with the import of nx-X11-3.5.0-2.tar.gz. Not needed, I guess.

> ./nx-X11/programs/Xserver/fb:
> -rw-rw-r-- 1 uli uli    1875 Okt 29 21:27 fbmodule.c        1)

Ok.

> -rw-rw-r-- 1 uli uli    1689 Okt 29 21:27 fb24_32.h

Does seem to be used. Neither in nxagent nor in X.org's Xserver.

> ./nx-X11/programs/Xserver/fb/module:
> -rw-rw-r-- 1 uli uli 167 Okt 29 21:27 Imakefile             1)

Ok.

> ./nx-X11/programs/Xserver/dix:
> -rw-rw-r-- 1 uli uli    1237 Okt 29 21:27 ffs.c             1)

The ffs function seems to be used when building on Win32 platforms. So
drop it.(?!)

> -rw-rw-r-- 1 uli uli    1234 Okt 29 21:27 buildatoms        2)

The file Xatom.h is empty in our source tree and gets populated at
build time. So, buildatoms cannot be removed. If it is not used at
build time, we should find out what is used to generate that file...

> ./nx-X11/programs/Xserver/Xext:
> -rw-rw-r-- 1 uli uli     437 Okt 29 21:27 xvmod.c           1)
> -rw-rw-r-- 1 uli uli     309 Okt 29 21:27 xvmodproc.h       1)

Ok.

> -rw-rw-r-- 1 uli uli    2358 Okt 29 21:27 xtest1.frags

Needs investigation, not sure what this file is for.

> -rw-rw-r-- 1 uli uli    1699 Okt 29 21:27 dpmsstubs.c

In theory we could drop the complete dpms code from the nxagent
Xserver as it gets stubbed in nxagent: https://github.com/ArcticaProject/nx-libs/blob/3.6.x/nx-X11/programs/Xserver/hw/nxagent/Init.c#L560

> -rw-rw-r-- 1 uli uli   34741 Okt 29 21:27 saver.c

Are you sure saver.c does not get compiled. This is a bug, maybe.

> ./nx-X11/programs/Xserver/Xext/extmod:
> -rw-rw-r-- 1 uli uli 1716 Okt 29 21:27 Imakefile            1)
> -rw-rw-r-- 1 uli uli 3563 Okt 29 21:27 modinit.c            1)

See PR#251...

> ./nx-X11/programs/Xserver/include:
> -rw-rw-r-- 1 uli uli  2393 Okt 29 21:27 rgb.h

This file does not get used, because we define USE_RGB_TEXT at build
time. Thus, we could think of removing the file + the USE_RGB_TEXT
macro, and thus enforce using an rgb text file. This rgb file logic
might even be switched over to using the X.org rgb file.

> ./nx-X11/programs/Xserver/hw/nxagent:
> -rw-rw-r-- 1 uli uli   14633 Okt 29 21:27 os2Stub.c         13)

Let's drop os2 support.

> -rw-rw-r-- 1 uli uli   53156 Okt 29 21:27 screensaver       11)

In Xnest (where nxagent got derived from), the screensaver file gets
included via Display.c. This needs further investigation.

> -rw-rw-r-- 1 uli uli    5446 Okt 29 21:27 Literals.h        12)

Don't touch.

> ./nx-X11/lib/X11:
> -rw-rw-r-- 1 uli uli    13877 Okt 29 21:27 os2Stubs.c       13)

Can be dropped.

> -rw-rw-r-- 1 uli uli    80426 Okt 29 21:27 jump_funcs
> -rw-rw-r-- 1 uli uli     3594 Okt 29 21:27 jump_ignore
> -rw-rw-r-- 1 uli uli     4570 Okt 29 21:27 jump_vars

I guess, these can be dropped.

> -rw-rw-r-- 1 uli uli     2317 Okt 29 21:27 lcDynamic.c      14)
> -rw-rw-r-- 1 uli uli     3595 Okt 29 21:27 XlcSL.c          14)

Probably a missing Imakefile entry, indeed.

> -rw-rw-r-- 1 uli uli     1814 Okt 29 21:27 Xaixlcint.h      13)

Ok.

> -rw-rw-r-- 1 uli uli    15503 Okt 29 21:27 XlcDL.c          14)
> -rw-rw-r-- 1 uli uli     6343 Okt 29 21:27 UIThrStubs.c     14)

Probably...

> -rw-rw-r-- 1 uli uli    40125 Okt 29 21:27 X11-def.cpp       8)

Ok.

> -rw-rw-r-- 1 uli uli    11611 Okt 29 21:27 XDefaultIMIF.c   14)
> -rw-rw-r-- 1 uli uli    26909 Okt 29 21:27 XDefaultOMIF.c   14)

Probably...

> ./nx-X11/lib/X11/lcUniConv:
> -rw-rw-r-- 1 uli uli  31002 Okt 29 21:27 cjk_tab_to_h.c     14)
> -rw-rw-r-- 1 uli uli  16887 Okt 29 21:27 8bit_tab_to_h.c    14)
> -rw-rw-r-- 1 uli uli    358 Okt 29 21:27 ascii.h            14)

Probably... However, .h files don't appear in the Imakefiles. The
ascii.h file requires more investigation and comparison with libX11
from X.org.

> ./nx-X11/lib/X11/util:
> -rw-rw-r-- 1 uli uli  246 Okt 29 21:27 mkks.sh

Probably not needed anymore.

> ./nx-X11/lib/X11/xlibi18n:
> -rw-rw-r-- 1 uli uli  234 Okt 29 21:27 Imakefile             6)
> -rw-rw-r-- 1 uli uli 3132 Okt 29 21:27 Xi18nLib.conf         6)

No idea, if these can be dropped completely. How about X.org?

> ./nx-X11/lib/X11/xlibi18n/im:
> -rw-rw-r-- 1 uli uli 296 Okt 29 21:27 Imakefile              6)

Ok.

> ./nx-X11/lib/X11/xlibi18n/im/ximcp:
> -rw-rw-r-- 1 uli uli 1767 Okt 29 21:27 Imakefile             6)
> -rw-rw-r-- 1 uli uli   41 Okt 29 21:27 Ximcp.mapfile         6)

No idea, if these can be dropped completely. How about X.org?

> ./nx-X11/lib/X11/xlibi18n/lc:
> -rw-rw-r-- 1 uli uli 303 Okt 29 21:27 Imakefile              6)
>
> ./nx-X11/lib/X11/xlibi18n/lc/def:
> -rw-rw-r-- 1 uli uli 256 Okt 29 21:27 Imakefile              6)
> -rw-rw-r-- 1 uli uli  48 Okt 29 21:27 Xlc.mapfile            6)
>
> ./nx-X11/lib/X11/xlibi18n/lc/gen:
> -rw-rw-r-- 1 uli uli 260 Okt 29 21:27 Imakefile              6)
> -rw-rw-r-- 1 uli uli  48 Okt 29 21:27 Xlc.mapfile            6)
>
> ./nx-X11/lib/X11/xlibi18n/lc/Utf8:
> -rw-rw-r-- 1 uli uli 265 Okt 29 21:27 Imakefile              6)
>
> ./nx-X11/lib/X11/xlibi18n/om:
> -rw-rw-r-- 1 uli uli 298 Okt 29 21:27 Imakefile              6)
>
> ./nx-X11/lib/X11/xlibi18n/om/generic:
> -rw-rw-r-- 1 uli uli 577 Okt 29 21:27 Imakefile              6)
> -rw-rw-r-- 1 uli uli  48 Okt 29 21:27 Xom.mapfile            6)

... All of the above... no clue really. Let's do what X.org does. (?).

> ./nx-X11/lib/xtrans:
> -rw-rw-r-- 1 uli uli 33194 Okt 29 21:27 Xtranstli.c          7)
> -rw-rw-r-- 1 uli uli 62486 Okt 29 21:27 Xtranslcl.c          7)
> -rw-rw-r-- 1 uli uli 26678 Okt 29 21:27 Xtransos2.c          7)
> -rw-rw-r-- 1 uli uli 14598 Okt 29 21:27 Xtransdnet.c         7)

Good. Dropping like upstream did. I though about this earlier, but did
not care so far.

> ./nx-X11/config/cf:
> -rw-rw-r-- 1 uli uli   1265 Okt 29 21:27 cross.def
> -rw-rw-r-- 1 uli uli   5004 Okt 29 21:27 cross.rules
> -rw-rw-r-- 1 uli uli  23935 Okt 29 21:27 README
> -rw-rw-r-- 1 uli uli   3964 Okt 29 21:27 ServerLib.tmpl

The README should stay. Have you grepped all Imakefiles and all files
in config/cf? Needs more investigation.

> ./nx-X11/extras/Mesa/src/mesa/shader/slang:
> -rw-rw-r-- 1 uli uli  4154 Okt 29 21:27 traverse_wrap.h
>
> ./nx-X11/extras/Mesa/src/mesa/shader/slang/library:
> -rw-rw-r-- 1 uli uli  3658 Okt 29 21:27 slang_vertex_builtin_gc.h
> -rw-rw-r-- 1 uli uli 48980 Okt 29 21:27 slang_core_gc_bin.h
> -rw-rw-r-- 1 uli uli  4276 Okt 29 21:27 slang_fragment_builtin_gc.h
> -rw-rw-r-- 1 uli uli 31197 Okt 29 21:27 slang_common_builtin_gc.h
>
> ./nx-X11/extras/Mesa/src/mesa/tnl:
> -rw-rw-r-- 1 uli uli 13695 Okt 29 21:27 t_vtx_x86.c
> -rw-rw-r-- 1 uli uli 17922 Okt 29 21:27 t_vtx_x86_gcc.S
>
> ./nx-X11/extras/Mesa/src/mesa/swrast:
> -rw-rw-r-- 1 uli uli   1239 Okt 29 21:27 s_trispan.h
> -rw-rw-r-- 1 uli uli   7140 Okt 29 21:27 s_spantemp.h
>
> ./nx-X11/extras/Mesa/include/GL:
> -rw-rw-r-- 1 uli uli   8455 Okt 29 21:27 osmesa.h

Please use grep and make sure that your build system is
nx-header-clean. I think the Mesa part needs more investigation, too.

Mike

DAS-NETZWERKTEAM mike gabriel, herweg 7, 24357 fleckeby mobile: +49 (1520) 1976 148 landline: +49 (4354) 8390 139

GnuPG Fingerprint: 9BFB AEE8 6C0A A5FF BF22 0782 9AF4 6B30 2577 1B31 mail: mike.gabriel@das-netzwerkteam.de, http://das-netzwerkteam.de

uli42 commented 7 years ago

On Sun, Oct 30, 2016 at 2:17 PM, Mike Gabriel notifications@github.com wrote:

On So 30 Okt 2016 02:08:29 CET, Ulrich Sibiller wrote:

The list below contains a number of files that have not been read during build on Ubuntu 14.04 (files that had not change their access time). I have commented on most of the files. For some of the files I have prepared a PR (pr/unused_files). Please have a look at it and comment.

  1. removed in my branch uli42:pr/unused files
  2. can generate initatoms.c and Xatom.h but these files are in the repo already
  3. shouldn't this come with autotools?
  4. required for Windows build, I think
  5. are only included when XKBSRV_NEED_FILE_FUNCS is set - which we do not
  6. drop completely?
  7. are dropped upstream, I am working on that
  8. what are those *-def.cpp files needed for?
  9. are these helper scripts still required?
  10. Keysyms for Apollo?
  11. have not found any reference for that file
  12. only used if compiling with TEST
  13. should be removed, along with all the #ifdef __UNIXOS2__ and AIX stuff
  14. maybe a missing makefile entry (missed while backporting?)
  15. see #255

install-sh can go away, in theory...

Ok, have opened a separate issue for that: #261

The winbuild of nx-X11 and a like is really non-maintained and to my sense we should really think about dropping that support. If someone steps out and seriously wants to continue / reintroduce Windows maintenance, this file can be re-added. But for now, we should drop it, IMHO. And with it, the Cygwin32 support for everything except nxcomp and nxproxy.

Is there really no need for nxcompext? And was there ever an agent for Windows? I have never seen that in action!

I would like to hear Ionic's opinion to this.

> -rw-rw-r-- 1 uli uli 1778 Okt 29 21:27 Xw32defs.h 4)
> -rw-rw-r-- 1 uli uli 2156 Okt 29 21:27 Xwindows.h 4)
> -rw-rw-r-- 1 uli uli 1881 Okt 29 21:27 Xwinsock.h 4)
> -rw-rw-r-- 1 uli uli 3971 Okt 29 21:27 XWDFile.h 4)

See above. Let's discontinue Win32/Cygwin support for nxagent.

> ./nx-X11/include/extensions:
> -rw-rw-r-- 1 uli uli 5487 Okt 29 21:27 vldXvMC.h
> -rw-rw-r-- 1 uli uli 1962 Okt 29 21:27 saver.h
> -rw-rw-r-- 1 uli uli 5130 Okt 29 21:27 saverproto.h
> -rw-rw-r-- 1 uli uli 4217 Okt 29 21:27 scrnsaver.h
> -rw-rw-r-- 1 uli uli 10220 Okt 29 21:27 Xvlib.h
> -rw-rw-r-- 1 uli uli 4377 Okt 29 21:27 XvMClib.h
> -rw-rw-r-- 1 uli uli 30853 Okt 29 21:27 XInput.h

This is strange. We build those extensions for nxagent. I just checked for Xserver/Xext/saver.c (which includes saver.h). Sometimes, we use <nx-X11/extensions/> as include statement and sometimes we use "". May it be that you built on a non-clean chroot?

The screensaver extension (MIT-SCREEN-SAVER) is not built by default, is has to be activated somewhere in nx-X11/config/cf. See also https://github.com/ArcticaProject/nx-libs/issues/80

The XvMC extension is indeed included. But the the three Xv files above are not referenced anywhere and belong to libxvmc-dev and x11proto-video-dev. So I think we are save dropping them. Same for XInput.h.

If you build locally, at least remove/purge all nx related .deb packages from your system. My impression is that those files got used, but from the system installation rather than from your local copy of code. _ This should not be relevant as we are having our nx-X11 and X11 paths first in the include search order.

> -rw-rw-r-- 1 uli uli 5126 Okt 29 21:27 XKBrules.h 5)
> -rw-rw-r-- 1 uli uli 11174 Okt 29 21:27 XKBfile.h 5)

Then (reason given in 5) ) we can drop them IMHO. I will first check if omitting XKBSRV_NEED_FILE_FUNCS is the right thing to do here.

> ./nx-X11/programs/Xserver:
> -rwxrwxr-x 1 uli uli 1088 Okt 29 21:27 fix-miregion 9)
> -rwxrwxr-x 1 uli uli 471 Okt 29 21:27 fix-miregion-private 9)
> -rwxrwxr-x 1 uli uli 1905 Okt 29 21:27 fix-region 9)

I added these more for the purpose of documentation. (Like X.org did, too). Basically, they can go away.

So, you decide.

> ./nx-X11/programs/Xserver/dix:
> -rw-rw-r-- 1 uli uli 1237 Okt 29 21:27 ffs.c 1)

The ffs function seems to be used when building on Win32 platforms. So drop it.(?!)

Depends on the "drop windows" discussion above.

> -rw-rw-r-- 1 uli uli 1234 Okt 29 21:27 buildatoms 2)

The file Xatom.h is empty in our source tree and gets populated at build time. So, buildatoms cannot be removed. If it is not used at build time, we should find out what is used to generate that file...

./nx-X11/include/Xatom.h came in from original nx tars and is not emtpy here: It has this near the beginning:

/* THIS IS A GENERATED FILE
 *
 * Do not change!  Changing this file implies a protocol change!
 */

We are just not (re-)creating it. Question is: should we?

> -rw-rw-r-- 1 uli uli 2358 Okt 29 21:27 xtest1.frags

Needs investigation, not sure what this file is for.

Its a help for developers. First lines:

There are several code fragments that need to be placed in the device
dependent part of the server.  These are described below.  These code
fragments are device and implementation dependent.

So it could be dropped, I think.

> -rw-rw-r-- 1 uli uli 1699 Okt 29 21:27 dpmsstubs.c

In theory we could drop the complete dpms code from the nxagent Xserver as it gets stubbed in nxagent: https://github.com/ArcticaProject/nx-libs/blob/3.6.x/nx-X11/programs/Xserver/hw/nxagent/Init.c#L560

Hmm, dpmsstubs.c is probably for exactly that purpose. Maybe use it instead?

However, removal of the extension might disturb some apps the rely on it being there, just like we see with MIT-SCREEN-SAVER:

> > -rw-rw-r-- 1 uli uli 34741 Okt 29 21:27 saver.c
> ```
>
> Are you sure saver.c does not get compiled. This is a bug, maybe.

Yes, I am, see above.

> ```
> > ./nx-X11/programs/Xserver/include:
> > -rw-rw-r-- 1 uli uli 2393 Okt 29 21:27 rgb.h
> ```
>
> This file does not get used, because we define USE_RGB_TEXT at build
> time. Thus, we could think of removing the file + the USE_RGB_TEXT
> macro, and thus enforce using an rgb text file. This rgb file logic
> might even be switched over to using the X.org rgb file.

What just came to my mind: Is rgb.txt provided on a system that
otherwise does not offer an Xserver (and only Xlibs?).

./nx-X11/programs/Xserver/hw/nxagent: -rw-rw-r-- 1 uli uli 14633 Okt 29 21:27 os2Stub.c 13)

Let's drop os2 support.

Yep.

> -rw-rw-r-- 1 uli uli 53156 Okt 29 21:27 screensaver 11)

In Xnest (where nxagent got derived from), the screensaver file gets included via Display.c. This needs further investigation.

OK, separate issue.

> -rw-rw-r-- 1 uli uli 5446 Okt 29 21:27 Literals.h 12)

Don't touch.

> ./nx-X11/lib/X11:
> -rw-rw-r-- 1 uli uli 13877 Okt 29 21:27 os2Stubs.c 13)

Can be dropped.

> -rw-rw-r-- 1 uli uli 2317 Okt 29 21:27 lcDynamic.c 14)
> -rw-rw-r-- 1 uli uli 3595 Okt 29 21:27 XlcSL.c 14)

Probably a missing Imakefile entry, indeed.

> -rw-rw-r-- 1 uli uli 1814 Okt 29 21:27 Xaixlcint.h 13)

Ok.

> -rw-rw-r-- 1 uli uli 15503 Okt 29 21:27 XlcDL.c 14)
> -rw-rw-r-- 1 uli uli 6343 Okt 29 21:27 UIThrStubs.c 14)

Probably...

> -rw-rw-r-- 1 uli uli 11611 Okt 29 21:27 XDefaultIMIF.c 14)
> -rw-rw-r-- 1 uli uli 26909 Okt 29 21:27 XDefaultOMIF.c 14)

Probably...

> ./nx-X11/lib/X11/lcUniConv:
> -rw-rw-r-- 1 uli uli 31002 Okt 29 21:27 cjk_tab_to_h.c 14)
> -rw-rw-r-- 1 uli uli 16887 Okt 29 21:27 8bit_tab_to_h.c 14)
> -rw-rw-r-- 1 uli uli 358 Okt 29 21:27 ascii.h 14)

Probably... However, .h files don't appear in the Imakefiles. The ascii.h file requires more investigation and comparison with libX11 from X.org.

-> separate issue (#265)

> ./nx-X11/lib/X11/xlibi18n:
> -rw-rw-r-- 1 uli uli 234 Okt 29 21:27 Imakefile 6)
> -rw-rw-r-- 1 uli uli 3132 Okt 29 21:27 Xi18nLib.conf 6)

No idea, if these can be dropped completely. How about X.org?

> ./nx-X11/lib/X11/xlibi18n/im:
> -rw-rw-r-- 1 uli uli 296 Okt 29 21:27 Imakefile 6)

Ok.

> ./nx-X11/lib/X11/xlibi18n/im/ximcp:
> -rw-rw-r-- 1 uli uli 1767 Okt 29 21:27 Imakefile 6)
> -rw-rw-r-- 1 uli uli 41 Okt 29 21:27 Ximcp.mapfile 6)

No idea, if these can be dropped completely. How about X.org?

-> separate issue (#264)

> ./nx-X11/lib/xtrans:

Good. Dropping like upstream did. I though about this earlier, but did not care so far.

I have begun twice doing that but I am not finished yet.

> ./nx-X11/config/cf:
> -rw-rw-r-- 1 uli uli 1265 Okt 29 21:27 cross.def
> -rw-rw-r-- 1 uli uli 5004 Okt 29 21:27 cross.rules
> -rw-rw-r-- 1 uli uli 23935 Okt 29 21:27 README
> -rw-rw-r-- 1 uli uli 3964 Okt 29 21:27 ServerLib.tmpl

The README should stay. Have you grepped all Imakefiles and all files in config/cf? Needs more investigation.

cross* are only included into xorg.cf when CrossCompiling is set. Do we ever need that?

ServerLib.tmpl needs further investigation.

> ./nx-X11/extras/Mesa/src/mesa/shader/slang:
> -rw-rw-r-- 1 uli uli 4154 Okt 29 21:27 traverse_wrap.h
>
> ./nx-X11/extras/Mesa/src/mesa/shader/slang/library:
> -rw-rw-r-- 1 uli uli 3658 Okt 29 21:27 slang_vertex_builtin_gc.h
> -rw-rw-r-- 1 uli uli 48980 Okt 29 21:27 slang_core_gc_bin.h
> -rw-rw-r-- 1 uli uli 4276 Okt 29 21:27 slang_fragment_builtin_gc.h
> -rw-rw-r-- 1 uli uli 31197 Okt 29 21:27 slang_common_builtin_gc.h
>
> ./nx-X11/extras/Mesa/src/mesa/tnl:
> -rw-rw-r-- 1 uli uli 13695 Okt 29 21:27 t_vtx_x86.c
> -rw-rw-r-- 1 uli uli 17922 Okt 29 21:27 t_vtx_x86_gcc.S
>
> ./nx-X11/extras/Mesa/src/mesa/swrast:
> -rw-rw-r-- 1 uli uli 1239 Okt 29 21:27 s_trispan.h
> -rw-rw-r-- 1 uli uli 7140 Okt 29 21:27 s_spantemp.h
>
> ./nx-X11/extras/Mesa/include/GL:
> -rw-rw-r-- 1 uli uli 8455 Okt 29 21:27 osmesa.h

Please use grep and make sure that your build system is nx-header-clean. I think the Mesa part needs more investigation, too.

Yep.

sunweaver commented 7 years ago

On So 30 Okt 2016 19:20:55 CET, Ulrich Sibiller wrote:

On Sun, Oct 30, 2016 at 2:17 PM, Mike Gabriel
notifications@github.com wrote:

On So 30 Okt 2016 02:08:29 CET, Ulrich Sibiller wrote:

install-sh can go away, in theory...

Ok, have opened a separate issue for that: #261

Seen that. Let me know if I should work on this or you.

The winbuild of nx-X11 and a like is really non-maintained and to my sense we should really think about dropping that support. If someone steps out and seriously wants to continue / reintroduce Windows maintenance, this file can be re-added. But for now, we should drop it, IMHO. And with it, the Cygwin32 support for everything except nxcomp and nxproxy.

Is there really no need for nxcompext? And was there ever an agent for Windows? I have never seen that in action!

Wait. I think there is a need for nxcompext. Why do you get to this
conclusion?

About nxagent on Win32 platforms. Never seen that either.

I would like to hear Ionic's opinion to this.

And @mikdep333's opinion, as he is a Cygwin guy and our potential maintainer.

> -rw-rw-r-- 1 uli uli 1778 Okt 29 21:27 Xw32defs.h 4)
> -rw-rw-r-- 1 uli uli 2156 Okt 29 21:27 Xwindows.h 4)
> -rw-rw-r-- 1 uli uli 1881 Okt 29 21:27 Xwinsock.h 4)
> -rw-rw-r-- 1 uli uli 3971 Okt 29 21:27 XWDFile.h 4)

See above. Let's discontinue Win32/Cygwin support for nxagent.

> ./nx-X11/include/extensions:
> -rw-rw-r-- 1 uli uli 5487 Okt 29 21:27 vldXvMC.h
> -rw-rw-r-- 1 uli uli 1962 Okt 29 21:27 saver.h
> -rw-rw-r-- 1 uli uli 5130 Okt 29 21:27 saverproto.h
> -rw-rw-r-- 1 uli uli 4217 Okt 29 21:27 scrnsaver.h
> -rw-rw-r-- 1 uli uli 10220 Okt 29 21:27 Xvlib.h
> -rw-rw-r-- 1 uli uli 4377 Okt 29 21:27 XvMClib.h
> -rw-rw-r-- 1 uli uli 30853 Okt 29 21:27 XInput.h

This is strange. We build those extensions for nxagent. I just checked for Xserver/Xext/saver.c (which includes saver.h). Sometimes, we use <nx-X11/extensions/> as include statement and sometimes we use "". May it be that you built on a non-clean chroot?

The screensaver extension (MIT-SCREEN-SAVER) is not built by default, is has to be activated somewhere in nx-X11/config/cf. See also https://github.com/ArcticaProject/nx-libs/issues/80

Ah. Ok. Maybe we should enable it. I will check that.

The XvMC extension is indeed included. But the the three Xv files above are not referenced anywhere and belong to libxvmc-dev and x11proto-video-dev. So I think we are save dropping them.

The Qindel people have some plans for working on Xv extension. So I am
a bit hesitating here.

Same for XInput.h.

Ok. X.org does not have it anymore, either.

If you build locally, at least remove/purge all nx related .deb packages from your system. My impression is that those files got used, but from the system installation rather than from your local copy of code. _ This should not be relevant as we are having our nx-X11 and X11 paths first in the include search order.

Please double check, if the include order really saves you from that.
And we really need to get you into clean chroot building of code.

> -rw-rw-r-- 1 uli uli 5126 Okt 29 21:27 XKBrules.h 5)
> -rw-rw-r-- 1 uli uli 11174 Okt 29 21:27 XKBfile.h 5)

Then (reason given in 5) ) we can drop them IMHO. I will first check if omitting XKBSRV_NEED_FILE_FUNCS is the right thing to do here.

Ack.

> ./nx-X11/programs/Xserver:
> -rwxrwxr-x 1 uli uli 1088 Okt 29 21:27 fix-miregion 9)
> -rwxrwxr-x 1 uli uli 471 Okt 29 21:27 fix-miregion-private 9)
> -rwxrwxr-x 1 uli uli 1905 Okt 29 21:27 fix-region 9)

I added these more for the purpose of documentation. (Like X.org did, too). Basically, they can go away.

So, you decide.

I would leave them until we have upgraded all Xserver code to some
recent status (compared to X.org).

> ./nx-X11/programs/Xserver/dix:
> -rw-rw-r-- 1 uli uli 1237 Okt 29 21:27 ffs.c 1)

The ffs function seems to be used when building on Win32 platforms. So drop it.(?!)

Depends on the "drop windows" discussion above.

Yep.

> -rw-rw-r-- 1 uli uli 1234 Okt 29 21:27 buildatoms 2)

The file Xatom.h is empty in our source tree and gets populated at build time. So, buildatoms cannot be removed. If it is not used at build time, we should find out what is used to generate that file...

./nx-X11/include/Xatom.h came in from original nx tars and is not emtpy here: It has this near the beginning:

/* THIS IS A GENERATED FILE
 *
 * Do not change!  Changing this file implies a protocol change!
 */

We are just not (re-)creating it. Question is: should we?

Actually, I had test-executed the buildatoms script and after that my
Xatom.h was empty. Personally, I think that we should re-create that
Xatom.h file, because it seems to be build cruft and has to align with
the actual implementation inside our Xserver.

> -rw-rw-r-- 1 uli uli 2358 Okt 29 21:27 xtest1.frags

Needs investigation, not sure what this file is for.

Its a help for developers. First lines:

There are several code fragments that need to be placed in the device
dependent part of the server.  These are described below.  These code
fragments are device and implementation dependent.

So it could be dropped, I think.

Yes.

> -rw-rw-r-- 1 uli uli 1699 Okt 29 21:27 dpmsstubs.c

In theory we could drop the complete dpms code from the nxagent Xserver as it gets stubbed in nxagent: https://github.com/ArcticaProject/nx-libs/blob/3.6.x/nx-X11/programs/Xserver/hw/nxagent/Init.c#L560

Hmm, dpmsstubs.c is probably for exactly that purpose. Maybe use it instead?

However, removal of the extension might disturb some apps the rely on it being there, just like we see with MIT-SCREEN-SAVER:

I have work on Xserver/Xext on my list anyway. Let me look at that.

> > -rw-rw-r-- 1 uli uli 34741 Okt 29 21:27 saver.c
> ```
>
> Are you sure saver.c does not get compiled. This is a bug, maybe.

Yes, I am, see above.

Ack.

> ./nx-X11/programs/Xserver/include:
> -rw-rw-r-- 1 uli uli 2393 Okt 29 21:27 rgb.h

This file does not get used, because we define USE_RGB_TEXT at build time. Thus, we could think of removing the file + the USE_RGB_TEXT macro, and thus enforce using an rgb text file. This rgb file logic might even be switched over to using the X.org rgb file.

What just came to my mind: Is rgb.txt provided on a system that otherwise does not offer an Xserver (and only Xlibs?).

On Debian systems, rgb.txt is shipped with x11-common. That package
also contains Xsession scripts and such. Not sure how other non-.deb
distros handle that.

What happens, if rgb.txt is missing? Do we know that?

> > ./nx-X11/programs/Xserver/hw/nxagent:
> > -rw-rw-r-- 1 uli uli 14633 Okt 29 21:27 os2Stub.c 13)
> ```
>
> Let's drop os2 support.

Yep.

>
> ```
> > -rw-rw-r-- 1 uli uli 53156 Okt 29 21:27 screensaver 11)
> ```
>
> In Xnest (where nxagent got derived from), the screensaver file gets
> included via Display.c. This needs further investigation.

OK, separate issue.

>
> ```
> > -rw-rw-r-- 1 uli uli 5446 Okt 29 21:27 Literals.h 12)
> ```
>
> Don't touch.
>
> ```
> > ./nx-X11/lib/X11:
> > -rw-rw-r-- 1 uli uli 13877 Okt 29 21:27 os2Stubs.c 13)
> ```
>
> Can be dropped.
>
> ```
> > -rw-rw-r-- 1 uli uli 2317 Okt 29 21:27 lcDynamic.c 14)
> > -rw-rw-r-- 1 uli uli 3595 Okt 29 21:27 XlcSL.c 14)
> ```
>
> Probably a missing Imakefile entry, indeed.
>
> ```
> > -rw-rw-r-- 1 uli uli 1814 Okt 29 21:27 Xaixlcint.h 13)
> ```
>
> Ok.
>
> ```
> > -rw-rw-r-- 1 uli uli 15503 Okt 29 21:27 XlcDL.c 14)
> > -rw-rw-r-- 1 uli uli 6343 Okt 29 21:27 UIThrStubs.c 14)
> ```
>
> Probably...
>
> ```
> > -rw-rw-r-- 1 uli uli 11611 Okt 29 21:27 XDefaultIMIF.c 14)
> > -rw-rw-r-- 1 uli uli 26909 Okt 29 21:27 XDefaultOMIF.c 14)
> ```
>
> Probably...
>
> ```
> > ./nx-X11/lib/X11/lcUniConv:
> > -rw-rw-r-- 1 uli uli 31002 Okt 29 21:27 cjk_tab_to_h.c 14)
> > -rw-rw-r-- 1 uli uli 16887 Okt 29 21:27 8bit_tab_to_h.c 14)
> > -rw-rw-r-- 1 uli uli 358 Okt 29 21:27 ascii.h 14)
> ```
>
> Probably... However, .h files don't appear in the Imakefiles. The
> ascii.h file requires more investigation and comparison with libX11
> from X.org.

-> separate issue (#265)

>
> ```
> > ./nx-X11/lib/X11/xlibi18n:
> > -rw-rw-r-- 1 uli uli 234 Okt 29 21:27 Imakefile 6)
> > -rw-rw-r-- 1 uli uli 3132 Okt 29 21:27 Xi18nLib.conf 6)
> ```
>
> No idea, if these can be dropped completely. How about X.org?
>
> ```
> > ./nx-X11/lib/X11/xlibi18n/im:
> > -rw-rw-r-- 1 uli uli 296 Okt 29 21:27 Imakefile 6)
> ```
>
> Ok.
>
> ```
> > ./nx-X11/lib/X11/xlibi18n/im/ximcp:
> > -rw-rw-r-- 1 uli uli 1767 Okt 29 21:27 Imakefile 6)
> > -rw-rw-r-- 1 uli uli 41 Okt 29 21:27 Ximcp.mapfile 6)
> ```
>
> No idea, if these can be dropped completely. How about X.org?

-> separate issue (#264)

>
> ```
> > ./nx-X11/lib/xtrans:
> ```
>
> Good. Dropping like upstream did. I though about this earlier, but did
> not care so far.

I have begun twice doing that but I am not finished yet.

> ```
> > ./nx-X11/config/cf:
> > -rw-rw-r-- 1 uli uli 1265 Okt 29 21:27 cross.def
> > -rw-rw-r-- 1 uli uli 5004 Okt 29 21:27 cross.rules
> > -rw-rw-r-- 1 uli uli 23935 Okt 29 21:27 README
> > -rw-rw-r-- 1 uli uli 3964 Okt 29 21:27 ServerLib.tmpl
> ```
>
> The README should stay. Have you grepped all Imakefiles and all files
> in config/cf? Needs more investigation.

cross* are only included into xorg.cf when CrossCompiling is set. Do
we ever need that?

Yes, let's keep that for now, then.

ServerLib.tmpl needs further investigation.

Ok.

> ./nx-X11/extras/Mesa/src/mesa/shader/slang:
> -rw-rw-r-- 1 uli uli 4154 Okt 29 21:27 traverse_wrap.h
>
> ./nx-X11/extras/Mesa/src/mesa/shader/slang/library:
> -rw-rw-r-- 1 uli uli 3658 Okt 29 21:27 slang_vertex_builtin_gc.h
> -rw-rw-r-- 1 uli uli 48980 Okt 29 21:27 slang_core_gc_bin.h
> -rw-rw-r-- 1 uli uli 4276 Okt 29 21:27 slang_fragment_builtin_gc.h
> -rw-rw-r-- 1 uli uli 31197 Okt 29 21:27 slang_common_builtin_gc.h
>
> ./nx-X11/extras/Mesa/src/mesa/tnl:
> -rw-rw-r-- 1 uli uli 13695 Okt 29 21:27 t_vtx_x86.c
> -rw-rw-r-- 1 uli uli 17922 Okt 29 21:27 t_vtx_x86_gcc.S
>
> ./nx-X11/extras/Mesa/src/mesa/swrast:
> -rw-rw-r-- 1 uli uli 1239 Okt 29 21:27 s_trispan.h
> -rw-rw-r-- 1 uli uli 7140 Okt 29 21:27 s_spantemp.h
>
> ./nx-X11/extras/Mesa/include/GL:
> -rw-rw-r-- 1 uli uli 8455 Okt 29 21:27 osmesa.h

Please use grep and make sure that your build system is nx-header-clean. I think the Mesa part needs more investigation, too.

Yep.

;-)

Mike

DAS-NETZWERKTEAM mike gabriel, herweg 7, 24357 fleckeby mobile: +49 (1520) 1976 148 landline: +49 (4354) 8390 139

GnuPG Fingerprint: 9BFB AEE8 6C0A A5FF BF22 0782 9AF4 6B30 2577 1B31 mail: mike.gabriel@das-netzwerkteam.de, http://das-netzwerkteam.de

Ionic commented 7 years ago

On 30.10.2016 07:20 PM, Ulrich Sibiller wrote:

On Sun, Oct 30, 2016 at 2:17 PM, Mike Gabriel notifications@github.com wrote:

On So 30 Okt 2016 02:08:29 CET, Ulrich Sibiller wrote: The winbuild of nx-X11 and a like is really non-maintained and to my sense we should really think about dropping that support. If someone steps out and seriously wants to continue / reintroduce Windows maintenance, this file can be re-added. But for now, we should drop it, IMHO. And with it, the Cygwin32 support for everything except nxcomp and nxproxy.

Is there really no need for nxcompext? And was there ever an agent for Windows? I have never seen that in action!

I would like to hear Ionic's opinion to this.

Hmm... I can't really give a clear opinion here. Theoretically, we don't need nxagent on Windows, although it might be buildable via Cygwin. The use is limited though - you'd be able to start NX sessions on Windows and start X11 applications in there, which might be a nice feature to have, but probably not very useful really. With the advent of Ubuntu on Windows 10, the situation might change though - if X11 is ever brought in as a first-class citizen (currently Microsoft doesn't support X11 in their Ubuntu on Windows environment at all.)

Apart from this, the file referenced here is from nxcompshad, which explicitly needs Windows support, as it's getting linked into nxproxy. I don't understand what you mean by nxcompext though, you probably mean nxcompshad. That file isn't unused though, but pulled in by nxcompshad/Poller.h if compiled on Windows.

nxcompshad is part of nxagent and not nxproxy, though, so... potentially we could get rid of it, I guess? Also of Win.cpp, but will need to adapt Poller.h in any case.

Mihai

sunweaver commented 7 years ago

Hi all,

On So 30 Okt 2016 23:57:06 CET, Mihai Moldovan wrote:

On 30.10.2016 07:20 PM, Ulrich Sibiller wrote:

On Sun, Oct 30, 2016 at 2:17 PM, Mike Gabriel
notifications@github.com wrote:

On So 30 Okt 2016 02:08:29 CET, Ulrich Sibiller wrote: The winbuild of nx-X11 and a like is really non-maintained and to my sense we should really think about dropping that support. If someone steps out and seriously wants to continue / reintroduce Windows maintenance, this file can be re-added. But for now, we should drop it, IMHO. And with it, the Cygwin32 support for everything except nxcomp and nxproxy.

Is there really no need for nxcompext? And was there ever an agent for Windows? I have never seen that in action!

I would like to hear Ionic's opinion to this.

Hmm... I can't really give a clear opinion here. Theoretically, we don't need nxagent on Windows, although it might be buildable via Cygwin. The use is limited though - you'd be able to start NX sessions on Windows and start X11 applications in there, which might be a nice feature to have, but
probably not very useful really. With the advent of Ubuntu on Windows 10, the
situation might change though - if X11 is ever brought in as a first-class citizen (currently Microsoft doesn't support X11 in their Ubuntu on Windows environment at all.)

Apart from this, the file referenced here is from nxcompshad, which
explicitly needs Windows support, as it's getting linked into nxproxy. I don't
understand what you mean by nxcompext though, you probably mean nxcompshad.
That file isn't unused though, but pulled in by nxcompshad/Poller.h if compiled on Windows.

nxcompshad is part of nxagent and not nxproxy, though, so... potentially we could get rid of it, I guess? Also of Win.cpp, but will need to
adapt Poller.h in any case.

Let's drop the Win32 support for now. If someone really ambitious pops
up regarding Win32 support for nxagent, then this person may dig out
files from Git history.

my 2¢

Mike

DAS-NETZWERKTEAM mike gabriel, herweg 7, 24357 fleckeby mobile: +49 (1520) 1976 148 landline: +49 (4354) 8390 139

GnuPG Fingerprint: 9BFB AEE8 6C0A A5FF BF22 0782 9AF4 6B30 2577 1B31 mail: mike.gabriel@das-netzwerkteam.de, http://das-netzwerkteam.de

uli42 commented 7 years ago

Apart from this, the file referenced here is from nxcompshad, which explicitly needs Windows support, as it's getting linked into nxproxy. I don't understand what you mean by nxcompext though, you probably mean nxcompshad. That

No, I have no deep insight of the nxcomp* libs. I was just wondering why Mike#1 was only refering to nxcomp and not nxcompext.

file isn't unused though, but pulled in by nxcompshad/Poller.h if compiled on Windows. nxcompshad is part of nxagent and not nxproxy, though, so... potentially we could get rid of it, I guess? Also of Win.cpp, but will need to adapt Poller.h in any case.

If nxcompshad is part of nxagent only we could also statically link it and keep it away from client-only installations.

BTW: Win.cpp contains a FIXME regarding ErrorExit, can we remove that?

sunweaver commented 7 years ago

This issue should be revisited after the 3.6.0.0 release and then fully fixed for 3.6.1.0.