search

ArcticaProject / nx-libs

nx-libs
Other
120 stars 39 forks source link

adapt to nxagent: Xnest: Implement xnestModifyPixmapHeader #348

Closed sunweaver closed 7 years ago

sunweaver commented 7 years ago

Consider and backport from X.org's Xnest:

commit b902c8abb6d03e68c93e13881a350523b5ac900c
Author: Michal Srb <msrb@novell.com>
Date:   Tue Aug 6 16:56:53 2013 +0200

    Xnest: Implement xnestModifyPixmapHeader

    Xnest variant of ModifyPixmapHeader that creates new Pixmap in parent X
    server if it's size is modified from 0x0 to anything bigger.

    xnestCreatePixmap doesn't create pixmap in parent X server if it has
    dimensions 0x0. If it is later resized and accessed, Xnest will be
    aborted with BadDrawable error from parent X server because it will
    use XID 0. This happens with ScratchPixmap, for example as used from
    XaceCensorImage. Applications using XACE crash Xnest.

    Reviewed-by: Adam Jackson <ajax@redhat.com>
sunweaver commented 7 years ago

nxagent's DDX already has (a different) implementation of X.org's commit b902c8abb6d03e68c93e13881a350523b5ac900c. Thus, closing.