cannot resume session in fullscreen mode

sunweaver commented 6 years ago

I noticed a peculariaty when playing with Arctica Greeter's Remote Logon feature.

With X2Go, at least, it is currently not possible to resume a session in fullscreen mode. This is, although the nxagent configuration (options file in X2Go) is fullscreen=1.

After some code reading, I am sure this needs to be addressed in nxagent itself, as the underlying framework (X2Go, client-side and server-side) does everything correctly IMHO.

In Screen.c in nxagentOpenScreen() there is a lot of if / then / else stuff going on that has an impact on the nxagentOption(Fullscreen) parameter.

This bug report is (a) for sharing the observation, (b) a request for feedback (have you seen this, too) and (c) a reminder for myself to work on this and get it fixed...

uli42 commented 6 years ago

In Reconnect.c we set nxagentResizeDesktopAtStartup = False.

Bool nxagentReconnectSession(void)
{
  char *nxagentOldKeyboard = NULL;

  nxagentResizeDesktopAtStartup = False;

This will disable fullscreen if the display size of the connecting client does not match the fullscreen size used by the previous client's display.

sunweaver commented 6 years ago

Hi,

On Mo 14 Mai 2018 12:03:51 CEST, Ulrich Sibiller wrote:

In Reconnect.c we set nxagentResizeDesktopAtStartup = False.
Bool nxagentReconnectSession(void)
{
  char *nxagentOldKeyboard = NULL;

  nxagentResizeDesktopAtStartup = False;
This will disable fullscreen if the display size of the connecting
client does not match the fullscreen size used by the previous
client's display.

But that is not what we might want, is it? I'll do some tests around this.

Mike --

DAS-NETZWERKTEAM mike gabriel, herweg 7, 24357 fleckeby mobile: +49 (1520) 1976 148 landline: +49 (4354) 8390 139

GnuPG Fingerprint: 9BFB AEE8 6C0A A5FF BF22 0782 9AF4 6B30 2577 1B31 mail: mike.gabriel@das-netzwerkteam.de, http://das-netzwerkteam.de

uli42 commented 6 years ago

Hmm, if the user does not allow resizing we cannot provide a fullscreen session. I have shadow sessions in mind where you surely do not want to resize.

uli42 commented 5 years ago

Can you please re-test with 3.5.99.18? I have tested that yesterday and it worked...

uli42 commented 4 years ago

ping

milovtim commented 3 years ago

Confirm the same problem.

X2Go Server v4.1.0.0 on Ubuntu 18.04, X2Go Client v4.1.2.2 on Windows 10. NXAGENT - Version 3.5.99.16

When try to resume suspended sessions client's window blinks (appear for a moment) and hide eventually. To avoid this I have to stop/start new session on every disconnect. Later I realized that maximum available option instead of fullscreen works fine in session resuming. But this is not fullscreen and it's easy to mix x2go-client window (red highlight) with in-session windows (green highlight)

uli42 commented 3 years ago

What's the version of nxagent on your server?

milovtim commented 3 years ago

@uli42 NXAGENT - Version 3.5.99.16

uli42 commented 3 years ago

Please update to something current, we are at 3.5.99.26. See https://github.com/ArcticaProject/nx-libs#binary-builds where to get it.

On Wed, Jun 30, 2021 at 11:33 AM Timur @.***> wrote:

@uli42 NXAGENT - Version 3.5.99.16

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

milovtim commented 3 years ago

nxagent was updated to 3.5.99.26 -- fullscreen session is resuming fine now. Thanks for advice

ArcticaProject / nx-libs

cannot resume session in fullscreen mode #693