search

ArcticaProject / nx-libs

nx-libs
Other
120 stars 39 forks source link

Fix shellcheck issues #996

Closed mjtrangoni closed 3 years ago

mjtrangoni commented 3 years ago

Hi @sunweaver @uli42,

I fixed some shellcheck issues here, as I am working on integrating this tool to GitHub actions.

PTAL and test it!

Best regards,

Mario

mjtrangoni commented 3 years ago

@sunweaver @uli42 I realized now there are commits from you here. I am confused.

uli42 commented 3 years ago

Yes, it is a bit strange. It looks, like the merge commit got lost somehow. Showing current HEAD with tig hides it.

On Thu, Feb 4, 2021 at 12:00 PM Mario Trangoni notifications@github.com wrote:

@sunweaver https://github.com/sunweaver @uli42 https://github.com/uli42 I realized now there are commits from you here. I am confused.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ArcticaProject/nx-libs/pull/996#issuecomment-773221976, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABQHBZFIIC3Z2X5L7L3OEBDS5J457ANCNFSM4W3MLQNA .

sunweaver commented 3 years ago

Sigh, you are right. Something must have gone wrong while rebasing (and force-pushing the rebased branch to the PR update branch). Sorry for that. The shell fixes are in the code, so we have to live with this now. Right?

uli42 commented 3 years ago

I guess so.

On Thu, Feb 4, 2021 at 12:22 PM Mike Gabriel notifications@github.com wrote:

Sigh, you are right. Something must have gone wrong while rebasing (and force-pushing the rebased branch to the PR update branch). Sorry for that. The shell fixes are in the code, so we have to live with this now. Right?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.