Scientific Name Checker returns false "is accepted name" status

[sharpphyl]

Today I ran a list of names against Data Services: Scientific Name Checker.

The STATUS of a number of the taxon names was returned as "is accepted name" but when I opened the Arctos taxon record, the status is "invalid." Also, nothing was in the SUGGESTED_SCI_NAME column.

For example, Candidula gigaxii is listed as an accepted name.

But opening that taxon name shows that the status is invalid.

The valid name is Backeljaia gigaxii.

I thought perhaps it was because the WoRMS (via Arctos) name was invalid, but the Arctos name is also invalid.

Is this a bug? It would seem that the report should have shown the valid synonym for the taxon name I searched. I can always run a Taxon Match in WoRMS and just not use this report, but this could be a problem for other users too.

Also, can the scientific name checker be used to find the status of WoRMS (via Arctos) terms or only the status in the Arctos source?

[dustymc]

@Jegelewicz http://test.arctos.database.museum/Admin/gp.cfm should do what you need.

[Jegelewicz]

@dustymc I don't know what that is? But I got the header on the tool to stick, which is what I was after. That works, but if we want to Arctos header to stick (and I think we do), we probably need to futz with _header.cfm

Anyway, I think I have a good working tool template!

@sharpphyl please check this out: http://test.arctos.database.museum/DataServices/SciNameCheck.cfm

[Jegelewicz]

Here is what I see at http://test.arctos.database.museum/Admin/gp.cfm

[Jegelewicz]

@campmlc made some suggestions:

Make the sections in this order:

Tool Description Tool Instructions Tool Results File Upload (Use It!)

Plus maybe make them all expandable so the whole thing fits on a page?

[dustymc]

what that is

Change something then try.

futz with _header.cfm

https://github.com/ArctosDB/internal/issues/211 - you can, probably, but that will hopefully have a limited future. Anything that happens there needs to work at least as good as it does now on mobile, without CSS on, and under all existing customizations - pretty low bar but still a bar.

If you mean like the thing that won't go away when I scroll, that is EVIL - I want data on all of my screen, I have no extra space for static text.

[Jegelewicz]

what that is

Change something then try.

All righty-then!

[Jegelewicz]

Implemented suggestions in https://github.com/ArctosDB/arctos/issues/2253#issuecomment-733238857

@campmlc @sharpphyl check it out! http://test.arctos.database.museum/DataServices/SciNameCheck.cfm

[sharpphyl]

Definitely better but can we change the heading on the csv to be "taxon_name" instead of "scientific_name" since everything else is shifting that way? It appears we're changing the name of the tool to be Taxon Name Check (or Checker?) so it's parallel to the next service in the menu - Taxon Name Validator so can't we make the column headings the same for both reports? The Taxon Name Validator uses the heading "taxon_name."

Since there's only one column required, do we need the down arrow explanation? To me, it's just clutter.

Similarly, the output should be "taxon_name" as well.

Looks like the documentation link may need some work later too.

It's easier to decode if it says "click "Upload this file" although that's pretty obvious.

[Jegelewicz]

@sharpphyl I cannot make changes to what the tool will accept or what it puts out, so those are for @dustymc

Also, I took liberties with the title of the page assuming we would/could change it to Taxon Name Check - that's still up in the air.

What is wrong with the documentation link?

[sharpphyl]

What is wrong with the documentation link?

I'll go back and check but I think the link is fine. We'll just need to review the documentation and probably update it once we're all done. My comments was more a note to me than a request to do anything.

[Jegelewicz]

@dustymc well I somehow broke this thing? I was pretty sure I hadn't edited anything related to the functioning of the tool and it was working for me over the weekend, but now when I load a test file, I get this error:

An error occurred while processing this page! Message: Error invoking external process Detail: psql:/usr/local/webroot/temp/excopy_jegelewicz_20201201041236500_803.sql:1: ERROR: column "taxon_name" of relation "ds_temp_taxcheck" does not exist Check the Arctos Handbook for more information on errors.

This message has been logged as 45CAD039-A11D-4317-94485FC7F674AA0D Please contact us with any information that might help us to resolve this problem. For best results, include the error and a detail description of how it came to occur in the Issue.

File is attached. Taxon name checker test.zip

[dustymc]

Load a csv with one column titled “scientific_name.”

[Jegelewicz]

I swear that was what was in that file...

[Jegelewicz]

OK it works. Can we talk about changing everything to "taxon name" instead of "scientific name"?

[dustymc]

Yep, definitely, needs an Issue. It's potentially a fair bit of work, it's worth carefully fleshing out the terminology with the most diverse audience we can assemble before mashing any buttons.

[Jegelewicz]

@dustymc I am cleaning up junk left in this tool (SciNameCheck.cfm) and I moved all of the CSS to the style.css, but they do not flow through to the page in test. I think it is because of the v1239 in the last line of the alwaysinclude file? Just want to make sure that page style isn't lost with the next pull to production.

[dustymc]

v1239

Change it - that's just part of the "file name" as far as your browser knows, anything it hasn't seen before will result in it pulling the file, there's no rhyme or reason behind the number/string/variablename

[Jegelewicz]

URG - it is just the cashe! I'll try to remember that....but I'm not making any promises...

[Jegelewicz]

OK, this is done - propose to committee to close.

[sharpphyl]

@Jegelewicz

This is the issue that I meant to suggest we go ahead and close unless you want the committee to review it first. I'm fine with the way the Name Checker works now.