ArctosDB / arctos

Arctos is a museum collections management system
https://arctos.database.museum
59 stars 13 forks source link

Clean-up Taxonomy- ES collection - crystal/ mineral taxonomy #3080

Open Jegelewicz opened 3 years ago

Jegelewicz commented 3 years ago

Issue Documentation is http://handbook.arctosdb.org/how_to/How-to-Use-Issues-in-Arctos.html

Goal Appropriately describe mineral parts

Context geosample is too vague

Table https://arctos.database.museum/info/ctDocumentation.cfm?table=ctspecimen_part_name

Value crystal

Definition a solid material whose constituents (such as atoms, molecules, or ions) are arranged in a highly ordered microscopic structure, forming a crystal lattice that extends in all directions. Excludes polycrystals such as rocks. Wikipedia

Collection type ES

Attribute data type N/A

Attribute value N/A

Attribute units N/A

Part tissue flag No

Other ID BaseURL N/A

Priority Please assign a priority-label.

Jegelewicz commented 3 years ago

See concern at #3081

crystal = a solid material whose constituents (such as atoms, molecules, or ions) are arranged in a highly ordered microscopic structure, forming a crystal lattice that extends in all directions. Excludes polycrystals such as rocks.

geosample = sample of material from the Earth's crust

Again, it seems like all crystals are also geosamples.

Jegelewicz commented 3 years ago

@Nicole-Ridgwell-NMMNHS

With regard to the above and #2423, maybe we should treat "crystal" and "rock" (see #3081) as "geosample type" attributes of the part "geosample".

We can make use of existing vocabulary! See http://ldweb.ga.gov.au/def/ont/ga/igsn/igsn.html#MaterialType

Unfortunately, I can't open any of the links on this page, so I cannot find the vocabulary....

Jegelewicz commented 3 years ago

Finally got to this: https://app.geosamples.org/reference/materials.php

Jegelewicz commented 3 years ago

Other useful lists may be here as well https://www.geosamples.org/help/vocabularies

dustymc commented 3 years ago

No input on the terminology, but I do still like the trend of generalDiscoverableThing as part_name and specificMaybeObscureThing as a "sub-part" part attribute. That could be more data in https://arctos.database.museum/info/ctDocumentation.cfm?table=CTPART_ATTRIBUTE_PART or a/several new similar table(s).

Nicole-Ridgwell-NMMNHS commented 3 years ago

Having geosample as part name and rock/crystal as part attributes would be the biological equivalent to having "organism" as the only part name and everything else as an attribute. I'm not in favor of putting rock/crystal in an attribute. What is the point of having parts in geology if we're going to throw everything under the same part name?

dustymc commented 3 years ago

Thanks. I'm thinking closer to footbone as part with 3rd distal and phalange somehow attributed. Anything equivalent to skull humerus organism etc. should be "primary."

Jegelewicz commented 3 years ago

So should the things listed in that vocabulary be part names?

Nicole-Ridgwell-NMMNHS commented 3 years ago

We might eventually need to add some of those. Do we add them now, before they are necessary, or wait until someone actually needs them? If we do add them, I would simplify the list slightly: Gas Liquid Mineral Rock Sediment Soil

I've been going back and forth on whether to use mineral or crystal. I think I'm finally convinced to just use mineral because it will be more straightforward for searching.

dustymc commented 3 years ago

wait until someone actually needs them?

Always my preference.

Jegelewicz commented 3 years ago

OK, cool. So for now we add the following?

Mineral - A solid chemical compound with a fairly well-defined chemical composition and a specific crystal structure, that occurs naturally in pure form. https://en.wikipedia.org/wiki/Mineral Rock - Any naturally occurring solid mass or aggregate of minerals or mineraloid matter. https://en.wikipedia.org/wiki/Rock_(geology)

Change all "crystal" parts to "mineral" in the part bulkload, then load remaining parts?

Nicole-Ridgwell-NMMNHS commented 3 years ago

Yes

Jegelewicz commented 3 years ago

mineral added

dustymc commented 5 months ago

This is lost https://arctos.database.museum/name/Mineral, should not have been created, and needs moved to a disentangled state.

Data: temp_min.csv.zip

Summary:

---------------+-------
 NMMNH:Geol    |  1162
 TCDGM:Mineral |   839
 UAM:ES        |     2
 ALMNH:Paleo   |     2
 ALMNH:Geo     |     8

Contacts:

@Nicole-Ridgwell-NMMNHS @ufarrell @aklompma

ufarrell commented 5 months ago

hi @dustymc - not sure what disentangling involves in this case, let me know if I need to do something specific with the TCD records.

In case its relevent - I've been using this for a section of our mineral collection with blank labels and catalogue - hoping they can be project material for students/colleagues who will help put some IDs on them, this helps keep track of where they are and in some cases the attached images might be enough for an ID.

dustymc commented 5 months ago

@ufarrell thanks, yes that's very useful.

Because of how the taxonomy is shaped, I think the most consistent approach to that is probably to use https://arctos.database.museum/name/Mineral in the identification, and https://arctos.database.museum/info/ctDocumentation.cfm?table=ctspecimen_part_name#object (or maybe https://arctos.database.museum/info/ctDocumentation.cfm?table=ctspecimen_part_name#geosample, or even https://arctos.database.museum/info/ctDocumentation.cfm?table=ctspecimen_part_name#unknown) as the part. Basically,

  1. This is a mineral (because identification)
  2. There's something physical (part exists), and
  3. Everything we can say about the physical thing is already said by the identification (so generic part name).

There's definitely some blurry (at least for me...) line somewhere between identifications and parts for a lot of nonbiological stuff, I'm not suggesting that any of that's any sort of "how it should be done," I just think it's the most consistent approach (eg one that might provide one path to finding all similar material) - unless someone has a better view of that line, of course.

I'm happy to update things when and if anything starts looking workable.

Jegelewicz commented 5 months ago

I would modify @dustymc answer:

use https://arctos.database.museum/name/Mineral in the identification, and https://arctos.database.museum/info/ctDocumentation.cfm?table=ctspecimen_part_name#geosample

ufarrell commented 5 months ago

Ok, sounds good - I updated them all to 'geosample', keeping Mineral as the ID - let me know if any issue. A follow up question - if I have a mineral that IS identified, should the part type also be 'geosample'?

Jegelewicz commented 5 months ago

if I have a mineral that IS identified, should the part type also be 'geosample'?

Yep!

Jegelewicz commented 5 months ago

I changed the two ALMNH:Paleo

https://arctos.database.museum/guid/ALMNH:Paleo:10662 https://arctos.database.museum/guid/ALMNH:Paleo:10711

and removed mineral from their part list, but I don't have access to ALMNH:Geol. @babogan can you change those two or allow me access and I will?

Jegelewicz commented 5 months ago

@Nicole-Ridgwell-NMMNHS see https://github.com/ArctosDB/arctos/issues/3080#issuecomment-1976829444

Can we change your part names to geosample?

ufarrell commented 5 months ago

if I have a mineral that IS identified, should the part type also be 'geosample'?

Yep!

Ok done!

ufarrell commented 5 months ago

This is lost https://arctos.database.museum/name/Mineral, should not have been created, and needs moved to a disentangled state.

This caused me a bit of confusion - I think you meant https://arctos.database.museum/info/ctDocumentation.cfm?table=ctspecimen_part_name#mineral should not have been created? Just in case its confusing anyone else!

dustymc commented 5 months ago

EDIT I think I need more coffee, I'll try again.

Yes. https://arctos.database.museum/info/ctDocumentation.cfm?table=ctspecimen_part_name#mineral - created from https://github.com/ArctosDB/arctos/issues/3080#issuecomment-726268552 - looks like a weird way of saying https://arctos.database.museum/name/Mineral to me.

ufarrell commented 5 months ago

Hah, yes, I edited - having confused myself! In any case....ID fine, part name not fine is what I am taking away and I will go about my business with geosamples!

Nicole-Ridgwell-NMMNHS commented 5 months ago

I'm mostly on board with this, except that the classification isn't quite there to support this. See https://arctos.database.museum/search.cfm?guid_prefix=NMMNH%3AGeol&part_name=%3Dmineral vs https://arctos.database.museum/search.cfm?guid_prefix=NMMNH%3AGeol&taxon_name=mineral&part_name=%3Dmineral

Jegelewicz commented 5 months ago

except that the classification isn't quite there to support this

So we need to add Mineral to all of the "mineral" classifications?

Nicole-Ridgwell-NMMNHS commented 4 months ago

So we need to add Mineral to all of the "mineral" classifications?

Yes, I think so.

Jegelewicz commented 4 months ago

Updated classifications to include Kingdom = Mineral

Jegelewicz commented 4 months ago

@Nicole-Ridgwell-NMMNHS test this again?

Jegelewicz commented 4 months ago

Nevermind, I still have to deal with varieties....

dustymc commented 1 week ago

@Nicole-Ridgwell-NMMNHS can you help me resolve this? Is there some list of names which need a term added? Does anyone know where the Heys CIM (via Arctos) data came from- eg is there a csv that I might modify and reload? @mkoo know anything about any of this?

Jegelewicz commented 1 week ago

know where the Heys CIM (via Arctos) data came from

https://arctos.database.museum/info/ctDocumentation.cfm?table=cttaxonomy_source#heys_cim__via_arctos_

mkoo commented 1 week ago

in order to resolve this issue, @Nicole-Ridgwell-NMMNHS @dusty should meet to work out the clean-up issues. New part names is not going to resolve the current state. I can schedule a meeting separate from CT meetings

dustymc commented 1 week ago

@Nicole-Ridgwell-NMMNHS here are the taxa which don't have a 'mineral' term in the classification and use a 'mineral' part. I do not have sufficient knowledge to do anything about this. (I suppose I could start yet another 'rocks-n-dirt' classification that just says 'mineral' for these, but that seems somewhere between dumb and evil...)

temp_min_tax.csv

Any sort of number in the has_... columns indicates there's something in a classification that your collection uses, NULL==there's no classification. Not sure that's helpful at all...

If you don't have time to deal with this, I'll suggest bulkloading a less-accepted identification of 'mineral' to retain the functionality until someone can make the taxonomy more consistent. Happy to help with that, let me know.

Here's the list of GUIDs in the part search and not taxonomy, in case that's useful.

temp_mineral_misses.csv