ArctosDB / arctos

Arctos is a museum collections management system
https://arctos.database.museum
60 stars 13 forks source link

percent as units is a mess! #3626

Closed Jegelewicz closed 1 year ago

Jegelewicz commented 3 years ago

Goal percent exists in two different controlled vocabularies

Context Should it?

Table Percent is in https://arctos.database.museum/info/ctDocumentation.cfm?table=ctcount_units and https://arctos.database.museum/info/ctDocumentation.cfm?table=cttissue_volume_units

Value Should we pick a table for percent or is there a reason this needs to be in two places?

Definition N/A

Setting priority as high so we can avoid excess cleanup if we need to clean up.

Jegelewicz commented 3 years ago

for reference percent = one part in every hundred

Jegelewicz commented 3 years ago

I think we should leave this in count units and remove from volume because of the definition:

A number or ratio expressed as a fraction of 100. It is often denoted using the percent sign, "%", although the abbreviations "pct.", "pct" and sometimes "pc" are also used. A percentage is a dimensionless number (pure number); it has no unit of measurement. Wikipedia

Jegelewicz commented 2 years ago

Code table committee says it isn't a problem - closing

dustymc commented 1 year ago

Reopening and potentially expanding this.

I think percent is used only by https://arctos.database.museum/info/ctDocumentation.cfm?table=ctcoll_event_attr_type&field=relative%20humidity

Suggest we change that and remove the obviously-inappropriate value from the CT.

https://arctos.database.museum/info/ctDocumentation.cfm?table=ctspecpart_attribute_type#dna_absorbance_ratio_a260_a230 and https://arctos.database.museum/info/ctDocumentation.cfm?table=ctspecpart_attribute_type#dna_absorbance_ratio_a260_a280 seem to have been shoehorned through the CT process, are not used, and might benefit from whatever we do with humidity. Both are currently set up for free text and look like wildfires waiting for a spark; suggest we remove them from the CT until they can be properly structured.

dustymc commented 1 year ago

Meh, I'm un-panicking. Relative humidity uses https://arctos.database.museum/info/ctDocumentation.cfm?table=ctcount_units, I think that table doesn't have a great name but I don't have a better suggestion at the moment. Names aside, stuffing weird units that don't fit elsewhere into ctcount_units seems reasonable (ish, I think - until they're mis-used, maybe).

Reclosing this, percent as a volume (https://github.com/ArctosDB/arctos/issues/5718) still needs un-done.

campmlc commented 1 year ago

BTW - what happened to https://arctos.database.museum/info/ctDocumentation.cfm?table=ctspecpart_attribute_type#dna_absorbance_ratio_a260_a230 and https://arctos.database.museum/info/ctDocumentation.cfm?table=ctspecpart_attribute_type#dna_absorbance_ratio_a260_a280 ? We need these attributes - they are only unused because they took so long to implement that the data were never entered. But the data exist. I don't see the attributes in the code table?

dustymc commented 1 year ago

https://github.com/ArctosDB/arctos/issues/3624#issuecomment-1447293019