ArctosDB / dev

Current public release and project roadmap for development
https://arctos.database.museum
Apache License 2.0
0 stars 0 forks source link

Bug Report - error when using 'create' button to add admin contact #106

Closed mkoo closed 2 weeks ago

mkoo commented 3 weeks ago

Describe the bug

This collection (MVZ:Herp) does not appear to have a admin contact, so when trying to add an agent an error occurs. The error says its a dup value but I dont see it listed so could be insert bug or cache/ interface bug!

Firefox_Screenshot_2024-11-09T23-53-21 040Z

Error ERROR_ID 69FB687B-B8D7-4E1E-A27A978421767F94 ERROR_TYPE SQL ERROR_MESSAGE ERROR: duplicate key value violates unique constraint "ix_colct_cntc_agnt_role" Detail: Key (collection_id, contact_role, contact_agent_id)=(30, administrative contact, 10008698) already exists. ERROR_DETAIL
ERROR_SQL INSERT INTO collection_contacts ( collection_contact_id, collection_id, contact_role, contact_agent_id) VALUES ( nextval('sq_collection_contact_id'), 30, 'administrative contact', 10008698 )

-- needs to be understood and resolved so I can send out an alert to listservs

dustymc commented 3 weeks ago

I think this can be classified as a bug - there was an apparently-unjustified assumption that contacts will be operators, it seems reasonable that that's not necessarily the case, there's no problem with this and it will be changed for next release.

However, this does lead to another possible concern: there is a function which calculates addresses, and it returns NULL when the agent in question doesn't have an active operator account. (Lots of history and justification for this, short version is that Arctos will not be a source of spam for folks who don't have a way out.) So, for both manage collection and /collection/ pages, contacts without an open operator account will not report a GitHub or email, even if they have one in their agent profile. I'm not sure that can be changed, but perhaps we need additional documentation or ?????? (If so, issue here please.)