search

Arctosoft / Valv-Android

An encrypted gallery vault for Android
GNU General Public License v3.0
131 stars 6 forks source link

[BUG] - F-Droid build not reproducible #43

Closed linsui closed 9 months ago

linsui commented 9 months ago

Describe the bug In the json generated by aboutLibraries there is a block for androidx.media3:media3-exoplayer-hls but there is no such block in the F-Droid build.

To Reproduce Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior A clear and concise description of what you expected to happen.

Screenshots If applicable, add screenshots to help explain your problem.

Smartphone (please complete the following information):

Additional context Add any other context about the problem here.

hej2010 commented 9 months ago

Should I create a new release or is it enough to update the .apk in the two most recent releases?

hej2010 commented 9 months ago

I recompiled and uploaded the fixed .apk for release 1.6.0 and 1.6.1

linsui commented 9 months ago

Thanks!

licaon-kter commented 7 months ago

@hej2010 just a heads up, pls build APKs from the Tagged commit in the future,else this happens: https://gitlab.com/fdroid/fdroiddata/-/jobs/6515204066#L1664

fixed in: https://gitlab.com/fdroid/fdroiddata/-/commit/9f72a304b23c9435172b04c4c24c62ea9bbf7b4b

hej2010 commented 7 months ago

@hej2010 just a heads up, pls build APKs from the Tagged commit in the future,else this happens: https://gitlab.com/fdroid/fdroiddata/-/jobs/6515204066#L1664

fixed in: https://gitlab.com/fdroid/fdroiddata/-/commit/9f72a304b23c9435172b04c4c24c62ea9bbf7b4b

Ah, ok, I thought it was by version name/code only. Will do that in future updates :)

licaon-kter commented 7 months ago

Well, not sure why the APK has the "commithash" inside, but it is what it is. We see this in other apps too.

licaon-kter commented 2 months ago

ref: https://gitlab.com/fdroid/fdroiddata/-/jobs/7908196810#L370

difflog: valv30.log

@hej2010 maybe you can clean the caches and rebuild? attach the apk here so we can test

/LE: https://gitlab.com/fdroid/fdroiddata/-/commit/5758283eb75a1cf4bc2ea0688087c4eebab915bd

hej2010 commented 2 months ago

@licaon-kter Sure, here Vault_30_1.11.0_release.zip (could not upload .apk)

licaon-kter commented 1 month ago

I see that you've updated the APK in release :) and that one is repro :tada: https://gitlab.com/fdroid/fdroiddata/-/commit/c32a74ae05d1b45fecae7dd6637f6a453ae530d2