Price Module Validator Spec

ArdanaLabs / Ardana-dApps

BSD 3-Clause "New" or "Revised" License

2 stars 2 forks source link

Price Module Validator Spec #48

Closed epiro-ps closed 2 years ago

epiro-ps commented 2 years ago

Closes

other changes

[ ] Every newly introduced function needs to have a documentation
[ ] The impure tests via nix run .#offchain:test were run and all are passing.
[ ] Where applicable, grammar, punctuation, and spelling within code and comments should be plausibly correct.
[ ] The issue(s) that the work is addressing should be linked in the PR description.
[ ] Any significant changes beyond what's clear from the linked issue(s) are documented in the PR description

Geometer1729 commented 2 years ago

It should probably include that the history agrees with the previous utxo and we can probably remove checking that the history is all spaced by at least 1 hour cause we should get that for free anyway.

epiro-ps commented 2 years ago

It should probably include that the history agrees with the previous utxo and we can probably remove checking that the history is all spaced by at least 1 hour cause we should get that for free anyway.

I like that. Very blockchain solution.

Geometer1729 commented 2 years ago

Oh also AFAIK I can't check anything about slot numbers from onchain. AFAIK I can only examine the posix time range provided in the script context.

epiro-ps commented 2 years ago

Closing this PR in favor of this issue which may end up in the doc after review.