search

ArdaxHz / mdownloader

MangaDex downloader using python. Forked from the repo linked
https://gitlab.com/hitoribocchi/mdownloader
GNU General Public License v3.0
9 stars 1 forks source link

Delayed chapters failing #5

Closed NLZ closed 4 years ago

NLZ commented 4 years ago

Delayed chapters are failing because they have no server field in them (see example)

Here is the failing code, putting the status check before the server extraction seems to work. I would also add a print that skipping x chapter because y status.

https://github.com/Rudoal/mdownloader/blob/9114ed091215d9da60ee2f2526c78d6c9a214065/components/downloader.py#L100-L104

ArdaxHz commented 4 years ago

I was meant to add an option for delayed chapters from before but didn't do so, but I've added it in the upcoming update, 2.7.2.

NLZ commented 4 years ago

Oh, it still fails with externals, so I would move the server url extraction to somewhere before you call it:

https://github.com/Rudoal/mdownloader/blob/9114ed091215d9da60ee2f2526c78d6c9a214065/components/downloader.py#L142-L144