ArdeniusAI / CPlus_Ardenius

ComfyUI CPlus Control Box custom node
1 stars 3 forks source link

Your licensing model is invalid #1

Open NeedsMoar opened 5 months ago

NeedsMoar commented 5 months ago

this software and code © 2024 is licensed under Attribution-NonCommercial-NoDerivatives 4.0 International

( owner contact information ardenius7@gmail.com attribution link https://ko-fi.com/ardenius )

FREE FOR PERSONAL USE -- FOR COMMERCIAL USE visit https://ko-fi.com/ardenius

and is based upon code licensed under General Public License v3.0 https://www.gnu.org/licenses/gpl-3.0.txt by

contributers found here https://github.com/comfyanonymous/ComfyUI

thus all code here is released to the user.

GPL3 code cannot be legitimately converted to BY-NC-ND 4.0. The only Valid creative commons conversion is BY-SA 4.0 to GPL3. The terms of non-modification are incompatible.

Additionally, copyright only applies to substantially original works, which this isn't: There's no actual original code that can be covered by GPL3 since the majority is pass-through of inputs that are required to be used to interact with ComfyUI (aka there isn't an alternate implementation possible) and what little code there is just performs rounding of latent size to be divisible by 8 which isn't original, since this is an assumption / requirement of the underlying type.

Beyond the bizarre attempt at relicensing to something incompatible with GPL3 that isn't even normally used for software, you should probably delist this from comfyui-manager since as-is it'll only pull in a broken, empty node directory with a readme and the whole point of the manager is auto-updating the nodes, not making people go download them from a patreon and enter their email. There's a website dedicated to that sort of thing, it's called youtube, and most people avoid it.

I don't even particularly care and I personally think GPL3 is to be avoided at all costs but my reasoning for that is that it's viral and makes it incredibly difficult to change to a less restrictive license. Trying to change to a more restrictive one, especially for a non-compiled language, is lulzy on top of being broken. GPL3 allows for adding extra restrictions, too... it's just that the ones you're trying to add specifically aren't allowed, and effectively you're attempting to remove copyright ownership from the original contributors if anything here can actually be copyrighted, which is a violation of copyright law / IP theft under the listed terms.

ArdeniusAI commented 5 months ago

thank you very much for the thorough feedback. -emails are not registered when you download just put $0 and download at this link CPlus control box download -i am new to GitHub and just experimenting with this node to see what happens. then add more to it. -It should not give errors now: I add the files to the folder so it should work fine with the manager now. -i use this node everyday its working fine. i have not submitted it to the manager but i just saw it listed there which is awesome and i want people to use it for free and add to it in the near future. and more free nodes too. -as for the license, i am not trying to take license of the code, i am just trying to find a license that restricts commercial use by companies and make this and future free software available for the people not companies. the copyrights stuff is pretty confusing :)

ArdeniusAI commented 5 months ago

after some reading on licenses it seems like the only option for GPL V3.0 is to use the same license which is not bad.