Ardentwheel / OpenCore-Hasee-X57S1

OpenCore For Hasee KingBook X57S1
GNU General Public License v3.0
28 stars 12 forks source link

To-do list / Issue (problems) list #3

Closed m0d16l14n1 closed 1 year ago

m0d16l14n1 commented 4 years ago

New problems:

You can add something what i forgot to mention

m0d16l14n1 commented 4 years ago

Audio is fixed for now (working without FakePCIID stuff + with no pci device inject, don't forget to remove that stuff from your EFI) Still need to fix layout for headphones Thx to @zhen-zen and @fewtarius - https://github.com/fewtarius/AppleALC/commit/1dbba6491ea94eeef98b322254133d2f3e166f15 AppleALC.kext.zip

Ardentwheel commented 4 years ago

Audio is fixed for now (working without FakePCIID stuff + with no pci device inject, don't forget to remove that stuff from your EFI) Still need to fix layout for headphones Thx to @zhen-zen and @fewtarius - fewtarius/AppleALC@1dbba64 AppleALC.kext.zip

Yes, I tested the patch, now working without FakePCIID. And I made a pull request https://github.com/acidanthera/AppleALC/pull/613

m0d16l14n1 commented 4 years ago

@Ardentwheel is your 18 layout fixed problem with Headphones?

m0d16l14n1 commented 4 years ago

btw, audio is dead randomly after wake-sleep cycles, might we need hpet fix, or it's might be layout problem

ghost commented 4 years ago

btw, audio is dead randomly after wake-sleep cycles, might we need hpet fix, or it's might be layout problem

My gist that I linked you to previously may correct that.

https://gist.github.com/fewtarius/0ee689cf725c27c43af0aea83b04b882

m0d16l14n1 commented 4 years ago

My gist that I linked you to previously may correct that.

yeah, currently I did fix for hpet sound is okay after sleep. if there any problems more - I will sure did the things from your guide, especially about headphones, heh

fixed hpet.zip

ghost commented 4 years ago

The gist may also fix no sound after sleep for internal devices, it can be EAPD related.

m0d16l14n1 commented 4 years ago

Made some sleep-wake cycles, sound seems working okay now, still need to test it more

m0d16l14n1 commented 4 years ago

The gist may also fix no sound after sleep for internal devices, it can be EAPD related.

oh, got it. okay

Ardentwheel commented 4 years ago

headphone jack is connect via external line, dose have something to do with it ?

IMG_0374

m0d16l14n1 commented 4 years ago

Wi-Fi speeds over 5ghz on BCM94360NG has been fixed with using AirportBrcmFixup, i don't know why speeds are low by default, maybe it's problem with CNVI 2, which we have in our laptop. But at least it's working properly now.

On windows by default speed are okay with latest Fenvi drivers from their website. Router settings are set properly, i even tried to set aspm-default values, but that didn't work for macOS to work properly at 5ghz.

Only with the kext it's working with ~ same speed as in windows by default

m0d16l14n1 commented 4 years ago

headphone jack is connect via external line, dose have something to do with it ?

there should be no problem with that, that's usual way to connect usb/hp board to main board. nothing special

ghost commented 4 years ago

FYI - I've submitted the PR for the controller patch, it seems to also correct a no audio issue for someone with a Dell 7390.

https://github.com/acidanthera/AppleALC/pull/615

m0d16l14n1 commented 4 years ago

@fewtarius thanks!!

m0d16l14n1 commented 4 years ago

The HDMI issue might be fixed with new patch from FireWolf - https://github.com/acidanthera/WhateverGreen/pull/72 Once it will be merged - need to try it

m0d16l14n1 commented 4 years ago

About undervolting and stuff - seems to be possible to use undervolting (voltageshift) according to that guys - https://github.com/leon0410898/XPS13-9300-hackintosh

We have good bios and i see that stuff inside it (undervolt cpu, and modify PL1, PL2), so that's might be possible to make that without voltageshift at all.

Currently i just decreased turbo stuff from 3.6 ghz to 2.5 and temperatures now are fully okay (60-70*)

0xFireWolf commented 4 years ago

The HDMI issue might be fixed with new patch from FireWolf - acidanthera/WhateverGreen#72 Once it will be merged - need to try it

No, that PR is not related to HDMI on Ice Lake platforms.

The HDMI issue (not DisplayPort-over-Type-C to HDMI) is a complete new story.

Apple has removed HDMI support from the driver. While there are some leftover code related to HDMI in the driver, it is still unknown whether we could port the support back.

m0d16l14n1 commented 4 years ago

No, that PR is not related to HDMI on Ice Lake platforms.

The HDMI issue (not DisplayPort-over-Type-C to HDMI) is a complete new story.

Apple has removed HDMI support from the driver. While there are some leftover code related to HDMI in the driver, it is still unknown whether we could port the support back.

got it, okay, wow... thanks for the info, bad news :( will hope for HDMI support than, heh.

xenonstride commented 4 years ago

Text on the screen is really small, sometimes it's hard to read compare to Windows global scale to 125%. Is there any way to make it bigger? @m0d16l14n1 I used this website (https://comsysto.github.io/Display-Override-PropertyList-File-Parser-and-Generator-with-HiDPI-Support-For-Scaled-Resolutions/) to enable HiDPI and solve this issue which I also had

Ardentwheel commented 4 years ago

i use https://github.com/xzhih/one-key-hidpi and the screen goes black, in recovery mode to delete 9e5 folder and replace icons.plist

m0d16l14n1 commented 4 years ago

@Ardentwheel just put laptop to sleep and wake it, that's fix that issue with black screen

m0d16l14n1 commented 4 years ago

With latest Lilu and WhateverGreen i can't boot installer of Big Sur at all. Previously it stucked on WhateverGreen patching, now it's booting to logo, keep loading for 1 minute and automatically reboot. Strange

UPDATE: I did update all kexts, including OC 0.6.3 and tried to install latest Big Sur Beta 10 (before i tried beta 6), seems to be working now, at least no reboot, waiting for installer to boot

UPDATE2: Successfully installed, seems to be working ok Screenshot at Oct 19 22-44-53

m0d16l14n1 commented 4 years ago

Sleep with closing lid seems to be fixed with the update to Big Sur, now it's working properly. Power button is still unresponsible

p.s Cursor glitching seems to be fixed too.

m0d16l14n1 commented 4 years ago

Got the glitch of Apple logo to disappear after half of progress bar is done (Catalina-Big Sur beta 10) - after update to Big Sur 11,0,1 beta that's seems to be fixed. Now Apple logo not disappearing until progress bar fully loaded, after that i got black screen for 5-7 seconds and login screen appear. that's might be still strange, but something changed, heh

m0d16l14n1 commented 4 years ago

https://github.com/VoodooI2C/VoodooI2C/issues/399

m0d16l14n1 commented 4 years ago
  • [ ] Get the rid of brightness patches > better move to BrightnessKeys.kext / but i am not sure how to do that

https://github.com/acidanthera/bugtracker/issues/1309

Ab2774 commented 4 years ago
  • [ ] Get the rid of brightness patches > better move to BrightnessKeys.kext / but i am not sure how to do that

Hi @m0d16l14n1, have you tried YogaSMC? It has built-in brightness keys support and many Lenovo laptop features like Conversation Mode and Fn Lock Mode. Good luck.

m0d16l14n1 commented 4 years ago

Hi @m0d16l14n1, have you tried YogaSMC? It has built-in brightness keys support and many Lenovo laptops features like Conversation Mode and Fn lock. Good luck.

Isn't that supported for Lenovo laptops only?

Ab2774 commented 4 years ago

Hi @m0d16l14n1, have you tried YogaSMC? It has built-in brightness keys support and many Lenovo laptops features like Conversation Mode and Fn lock. Good luck.

Isn't that supported for Lenovo laptops only?

Oh, right, my mistake, I thought that you're using a Lenovo laptop.

m0d16l14n1 commented 4 years ago

I seems found the reason why our lid sleep sometimes is not working (screen is not turning off if close lid)

https://github.com/Ardentwheel/OpenCore-Hasee-X57S1/issues/7

m0d16l14n1 commented 4 years ago
  • [ ] Power button isn't working at all, or working randomly

It's working now with test-build of YogaSMC. Also Fn+F5 is responsive for brightness-, but Fn+F6 is working only at login screen, not in desktop screen (and you need to disable SIP for now, it might be fixed somehow in future, but now it's working more stable with SIP disabled

  • [ ] Test hibernation (not sure if it's really needed, but it's okay to check it)

Something strange about hibernation. I switched from AWAC to "Legacy RTC" in BIOS (so, i don't use SSDT for that) and i got problem with hibernation even on Windows now, heh. I set up config to check hibernation, also used HibernationFixup.kext and other stuff - but laptop is just going into sleep mode, not in hibernation. Tested that about a week or two, still no results. No kernel panics/RTC or CMOS errors. It's just not going to hibernation mode. @Ardentwheel If you can try to test it too - test it please. I am really want to know if it's work or not, because it's maybe can fix our touchpad (it might work after hibernation wake up). And it's might be better to open separate issue for that too.

m0d16l14n1 commented 4 years ago
  • [x] Power button isn't working at all, or working randomly
  • [x] Get the rid of brightness patches > better move to BrightnessKeys.kext / but i am not sure how to do that
  • [x] Get the rid of H_EC rename to EC (afaik it's not safe to use that kind of renames, already did on my EFI)

Power button + Fn+F5/Fn+F6 are working like they should wihout patches or SSDT with YogaSMC OOTB.

SIP should be DISABLED to get power button work like it should. (Shutdown menu appears if you hold it, previously there was no response to it at all)

m0d16l14n1 commented 4 years ago

About audio problem (with headphones stuff) I was trying to build my own layout, according to all dumps we managed to get (also dumps from Windows), but still i get no luck to get 4 speakers working at the same time + headphones. The best i got - 2 bottom speakers to work (they have more sound, so they are better than upper 2) + headphones. But still sound is not as good as Windows. I opened an issue about AppleALC stuff, i am not sure, but it's maybe somehow related to Ice Lake problem, because i really don't understand how to get all audio working correctly. But issue was closed :(

https://github.com/acidanthera/bugtracker/issues/1325

Ab2774 commented 4 years ago

Hi, your headphones problem may be caused by disabling Jack Sence in your PinConfig's codec, you can enable it like what I did here https://github.com/acidanthera/AppleALC/pull/618, or installing ALCPlugFix, terrible audio quality may be caused by lack of AppleHDA patches, see https://github.com/daliansky/XiaoMi-Pro-Hackintosh/issues/446. Hope that helps! Thanks

m0d16l14n1 commented 4 years ago

@Ab2774 isn't jack sense is more about audio quality stuff? In my case macOS don't even recognise headphones at all. You have the same one before jack sense fix or not?

Ab2774 commented 4 years ago

Hi, my issue was static noise from the headphones after sleep caused by disabling Jack Sence, AFAIK, macOS doesn't recognize it because it's not included in Platforms(N).xml nor the PinConfig, BTW, what ALC256 layout you're using? Thanks

m0d16l14n1 commented 4 years ago

Hi, my issue was static noise from the headphones after sleep caused by disabling Jack Sence, AFAIK, macOS doesn't recognize it because it's not included in Platforms(N).xml nor the PinConfig, BTW, what ALC256 layout you're using?

Got it. In my case macOS don't seems to recognise headphones at all. But they are included in platforms file. I told in that issue that i did my own layout and it's still working in the same way as it's working on already made layouts. (headphones path included correctly in platform file + pin config too)

I used 76 and 97. Some more layouts from Huawei laptops (14 or 17, i don't remember).

kprabhat248 commented 4 years ago

@Ardentwheel just put laptop to sleep and wake it, that's fix that issue with black screen

that help you it will not cause any issue to my big sur as i am having relatively smaller content display on 14 inch 1080 p display

m0d16l14n1 commented 4 years ago

that help you it will not cause any issue to my big sur as i am having relatively smaller content display on 14 inch 1080 p display

i didn't use hidpi for now, just because it's causing many issues on ice lake for now. example - youtube playback is glitching and can't play 8k videos, for example. but with native resolution it's much more stable. so if you will have any blinking issues - that's hidpi issues

kprabhat248 commented 4 years ago

Text on the screen is really small, sometimes it's hard to read compare to Windows global scale to 125%. Is there any way to make it bigger? @m0d16l14n1 I used this website (https://comsysto.github.io/Display-Override-PropertyList-File-Parser-and-Generator-with-HiDPI-Support-For-Scaled-Resolutions/) to enable HiDPI and solve this issue which I also had

how to do that

kprabhat248 commented 4 years ago

i never watch 4k you are watching 8k lol

kprabhat248 commented 4 years ago

@m0d16l14n1 help me to fix that lower scaling issues

m0d16l14n1 commented 4 years ago

i never watch 4k you are watching 8k lol

that's not the question of 8k, lol. i got blinking screen even if i was just using something graphics related / youtube playback + something else - i got screen blinking. it might be not the issue in your case.

how to do that

open the link and read through it, nothing special there

kprabhat248 commented 4 years ago

have you got hdmi support what s your laptop resolution and size

m0d16l14n1 commented 4 years ago

have you got hdmi support what s your laptop resolution and size

scroll above and you will find info about HDMI.

FullHD/IPS, 15,6

kprabhat248 commented 4 years ago

can you fix drm content on icelake processor

m0d16l14n1 commented 4 years ago

can you fix drm content on icelake processor

nope. DRM is not working on iGPU system only

kprabhat248 commented 4 years ago

fixed hidpi it is working great . now how to fix sleep as you told above to change platform id i have default 00852a

m0d16l14n1 commented 4 years ago

fixed hidpi it is working great . now how to fix sleep as you told above to change platform id i have default 00852a

change platform-id

Lorys89 commented 4 years ago

The HDMI issue might be fixed with new patch from FireWolf - acidanthera/WhateverGreen#72 Once it will be merged - need to try it

No, that PR is not related to HDMI on Ice Lake platforms.

The HDMI issue (not DisplayPort-over-Type-C to HDMI) is a complete new story.

Apple has removed HDMI support from the driver. While there are some leftover code related to HDMI in the driver, it is still unknown whether we could port the support back.

you have news? will you be able to repair the driver support, so as to make hdmi work on ice lake?