Ardot66 / DialogueTrees

A graph-based dialogue system
MIT License
9 stars 3 forks source link

Work around for Godot 4.3 Regression #7

Open Meythulhu opened 2 months ago

Meythulhu commented 2 months ago

Godot 4.3 had seen a big change with GraphEdits and GraphNodes, and as part of that, a new node has been introduced, but since it's not marked as internal, it will also return in GetChildren(), resulting in the important node being deleted, and subsequently attempting to write to invalid memory space, causing Godot to crash via a SIGSEGV signal.

This will fix issue #6 by providing the following workaround:

This has been tested with Start/Switch/Output Dialogue nodes, but not tested further with other nodes, and regression may be introduced in certain use cases.

Ardot66 commented 1 month ago

Thanks so much for figuring out what was causing this issue! I'm going to be starting up development on this plugin again, so I'll probably implement a similar fix and submit everything to the asset library soon.