search

ArduPilot / ArduRemoteID

RemoteID support using OpenDroneID
GNU General Public License v2.0
102 stars 50 forks source link

ID error when not set to params #133

Open dusan19 opened 1 year ago

dusan19 commented 1 year ago

In uint8_t Transport::arm_status_check():

if (!g.have_basic_id_info()) { // if there is no basic ID data stored in the parameters give warning. If basic ID data are streamed to RID device, // it will store them in the parameters ret += "ID "; }

but what if options param is set such that OPTIONS_DONT_SAVE_BASIC_ID_TO_PARAMETERS is enabled? Then basic ID would not be stored and there will always be an arm status check error.

BluemarkInnovations commented 10 months ago

@dusan19 Sorry somehow I missed this issue. What you state is not true. If the OPTIONS_DONT_SAVE_BASIC_ID_TO_PARAMETERS is enabled, it will use the Basic ID info that is streamed to the device. Only it is not stored permanently as parameter to the device. So yes you will get an arm status check error, if you do not stream BasicID data to the device and have this option set.