search

ArduPilot / ArduRemoteID

RemoteID support using OpenDroneID
GNU General Public License v2.0
93 stars 46 forks source link

Operator Location doesn't fail on CAN #54

Closed sborenstein-ift closed 1 year ago

sborenstein-ift commented 1 year ago

This may be a bug on the ArduPilot OpenDroneID library. When the operator location feed is turned off, the RID module does not detect this. Likely due to the AP module not failing and continuing to send stale data.

BluemarkInnovations commented 1 year ago

Maybe this is a feature.

In PR https://github.com/ArduPilot/ArduRemoteID/pull/79 I added a more sophisticated check in which the arm_status_check function will also fail if the flight controller keeps sending the same system/location packets.

In general it is true that the RID module will keep broadcasting the last received information. Also, if the operator location feed is turned off. The developer choice is a) broadcast the last known information b) make the information invalid.

For instance, in case of the location messages, it is more useful to broadcast the last known location, compared to make it invalid. Similar to the operator location. It is better to broadcast the last known information then no information at all.

tridge commented 1 year ago

fixed