make BLE device name and SSID the same

ArduPilot / ArduRemoteID

RemoteID support using OpenDroneID

GNU General Public License v2.0

100 stars 49 forks source link

make BLE device name and SSID the same #77

Open BluemarkInnovations opened 2 years ago

BluemarkInnovations commented 2 years ago

In the PR, the advertisement BLE name and the WiFi SSID have the same format.

use the last 4-chars of the UAS ID
if not available use the last 4-chars of the device MAC address
SSID can be override by the relevant parameter setting. In this PR, the BLE name is not updated in such a case.
both BLE and SSID start with RID_

BluemarkInnovations commented 2 years ago

or PR https://github.com/ArduPilot/ArduRemoteID/pull/73

It is always good to start with the oldest PRs first,. On the other hand I should have referenced this PR https://github.com/ArduPilot/ArduRemoteID/pull/73 here .

tridge commented 1 year ago

@BluemarkInnovations I've updated the PR and force pushed, but I'm really not sure this is a good idea. What if the user sets the same UAS_ID on two aircraft? We'd be able to see both now, but could not if we force the same BT ID.

BluemarkInnovations commented 1 year ago

@BluemarkInnovations I've updated the PR and force pushed, but I'm really not sure this is a good idea. What if the user sets the same UAS_ID on two aircraft? We'd be able to see both now, but could not if we force the same BT ID.

Not sure how the Android app works, but I assume it will show up as two devices. This week busy, but I can try to do some testing next week. I understand your point, but we are talking about a user that enters incorrect data i.e. is non-compliant.

The downside of the current existing implementation is that the used SSID name has no relation with the UAS_ID settings. I mean if you detect multiple RID SSIDs, you don't know which one to connect to if you want to change the settings of drone with UAD_ID A. So to me this PR has more benefits than drawbacks.

BluemarkInnovations commented 1 year ago

@tridge I have tested it with two db201 modules setting it to the same UAS ID settings. In the OpenDroneID app they are detected as two separate RID devices.

tridge commented 1 year ago

In the OpenDroneID app they are detected as two separate RID devices.

and when you see then in WIFI tool for web status? They will show as the same I like the fact that it is unique now