search

ArduPilot / MAVProxy

MAVLink proxy and command line ground station
GNU General Public License v3.0
466 stars 680 forks source link

motortest command argument help confusingly labels first input "motornum" #723

Open dwiel opened 4 years ago

dwiel commented 4 years ago

When running motortest the following help string is displayed:

motortest
GUIDED> Usage: motortest motornum type(0=percent, 1=PWM, 2=RC-passthru) value timeout(s) <count>

Labeling the first argument as motornum is quite confusing and a similar confusion has been resolved in the mission planner by changing labels from "Motor 1" to "Motor A". Perhaps something similar could be done here. Maybe the first argument should be labeled motor_test_sequence_index or similar. I would be happy to make a pull request if a better name is decided on. The relevant place in the code is here: https://github.com/ArduPilot/MAVProxy/blob/94d705b9477ed4be55c3e84b0792a3131f200895/MAVProxy/modules/mavproxy_relay.py#L67

faerietree commented 4 years ago

Maybe motor_test_sequence_start_index? Or is this testing the motor denoted with index only? Instead of circular clockwise test?