search

ArduPilot / MissionPlanner

Mission Planner Ground Control Station for ArduPilot (c# .net)
http://ardupilot.org/planner/
GNU General Public License v3.0
1.81k stars 2.42k forks source link

sending CAN_FORWARD requests when not in CAN UI (CRITICAL BUG) #3417

Closed tridge closed 2 months ago

tridge commented 2 months ago

MissionPlanner is sending CAN_FORWARD requests to the flight controller when not in the CAN UI. This is very nasty and we need to get this behaviour removed quickly. With ArduPilot 4.5.6 (current stable) this can cause the DroneCAN thread to consume 100% of resources, so that no messages can be sent on any telemetry link. I will be opening a PR soon to address this in ArduPilot. Even with that change it is still an extremely bad idea to be requesting CAN_FORWARD when the user has not opened the CAN UI. It could completely flood the telemetry link on lower bandwidth radios links to the point that the user loses all situational awareness.

tridge commented 2 months ago

the bug was caused by this PR: https://github.com/ArduPilot/MissionPlanner/pull/3299 thanks to @robertlong13 for finding this