search

ArduPilot / WebTools

GNU General Public License v3.0
26 stars 27 forks source link

Libraries: Ensure SHA padding #210

Closed landswellsong closed 3 weeks ago

landswellsong commented 4 weeks ago

Commits with leading zeroes in SHA would lose them in the number to string conversion, leading to a false-negative GitHub check

image

IamPete1 commented 4 weeks ago

Thanks, good find! We need the same fix in the AP periph check here:

https://github.com/ArduPilot/WebTools/blob/25dffb70a70381b52508d57cfe9d628bb7c9ac41/HardwareReport/HardwareReport.js#L1717

Can you do that fix too?

landswellsong commented 3 weeks ago

@IamPete1 done, but I don't have a suitable log to verify it

IamPete1 commented 3 weeks ago

I have tested, works as expected, Thanks!