search

ArduPilot / ardupilot

ArduPlane, ArduCopter, ArduRover, ArduSub source
http://ardupilot.org/
GNU General Public License v3.0
10.71k stars 17.17k forks source link

ADSB: _OFFSET_LAT, OFFSET_LON should be renamed to POS_X/Y/Z #12625

Open rmackay9 opened 4 years ago

rmackay9 commented 4 years ago

ADSB appears to use non-standard position offset parameter names, ADSB_OFFSET_LAT/LON which I think should be renamed to be ADSB_POS_X/Y/Z to be consistent with other sensors (wiki)

Maybe I'm misunderstanding but I don't see how a "LAT", "LON" parameter can be a good name for something that is in body frame.

Because users look at parameters directly a lot, I think we need to be careful about how we name things.

rmackay9 commented 4 years ago

@magicrub, this library is perhaps mostly your baby (at least originally) so maybe you have an opinion on this?

peterbarker commented 4 years ago

On Tue, 22 Oct 2019, Randy Mackay wrote:

ADSB appears to use non-standard position offset parameter names, ADSB_OFFSET_LAT/LON which I think should be renamed to be ADSB_POS_X/Y/Z to be consistent with other sensors (wiki)

Maybe I'm misunderstanding but I don't see how a "LAT", "LON" parameter can be a good name for something that is in body frame.

This is lateral and longitudinal (which are body frame), not latitude and longitude (obviously earth frame).

Both should be done with x/y for consistency, as you say.

magicrub commented 2 years ago

The weird part about this is the terminology is from the ADSB spec. It's obviously not ideal..