AP_RangeFinder: Benewake TFmini I2C driver should default to use correct I2C address

ArduPilot / ardupilot

ArduPlane, ArduCopter, ArduRover, ArduSub source

http://ardupilot.org/

GNU General Public License v3.0

10.98k stars 17.51k forks source link

AP_RangeFinder: Benewake TFmini I2C driver should default to use correct I2C address #13419

Closed rmackay9 closed 2 years ago

rmackay9 commented 4 years ago

As discussed on this wiki PR: https://github.com/ArduPilot/ardupilot_wiki/pull/2487 users of the Benewake TFMini I2C lidar must specifically set the RNGFNDx_ADDR parameter to 16. We should avoid the user having to specifically set this parameter by instead defaulting this parameter to "16" if this sensor is used,

Something similar has already been done in the LeddarVu8 driver.

IamPete1 commented 3 years ago

This is the code that should be copied across from the Leddar backend.

https://github.com/ArduPilot/ardupilot/blob/0ee8b452ab76306d83c6252bcb9dc458bd7380bb/libraries/AP_RangeFinder/AP_RangeFinder_LeddarVu8.cpp#L90-L96

rmackay9 commented 2 years ago

i think we can close this now, thanks @shiv-tyagi !