search

ArduPilot / ardupilot

ArduPlane, ArduCopter, ArduRover, ArduSub source
http://ardupilot.org/
GNU General Public License v3.0
10.92k stars 17.41k forks source link

Rover: Add support for TSYS01 driver #13946

Open kklemens opened 4 years ago

kklemens commented 4 years ago

Feature request

Customer request to add support for the Celsius Fast-Response, ±0.1°C Temperature Sensor (I2C) for ArduRover.

Support for the Library and Driver were added in 2017, but only for ArduSub, no other firmware type. AP_TemperatureSensor: Add AP_TemperatureSensor library and TSYS01 driver

Is your feature request related to a problem? Please describe. No technical issue other than this driver is missing from Rover.

Describe the solution you'd like Please include support for this sensor in ArduRover. In QGroundControl for Sub, the readings show up under the "Temperature (3)" value.

Describe alternatives you've considered According to the Peripheral Hardware section of ArduRover, there are no other external temperature sensor options other than the one for reading internal temperature of the autopilot.

Platform [ ] All [ ] AntennaTracker [ ] Copter [ ] Plane [X] Rover [ ] Submarine

Additional context Useful for obtaining surface water temperature readings.

gokulp01 commented 4 years ago

Hi, @khancyr @kklemens could you take a look at the PR #14239 I think this should solve the issue. Any disrepencies let me know :)

kklemens commented 4 years ago

I can test once its in master with one of the sensors, but I'm not super great at testing PRs. Thank you very much for doing this though! It will help with things in the future ;)

peterbarker commented 3 years ago

@kklemens are you still interested in this functionality?

Sadly we do require code to be tested before it goes into master, rather than after :-)

I can build you binaries easily enough once we have a workable PR.

kklemens commented 3 years ago

@peterbarker I haven't had many more customer requests, so low priority.

If you do get a binary together, I'd be happy to test it on a Pixhawk 1 and using one of these sensors. kevin@bluerobotics.com

rmackay9 commented 2 years ago

By the way, for boats, sonar often provide the water temperature and our NMEA 0183 driver supports this and logs it to the DPTH message.

hendjoshsr71 commented 2 years ago

Removed the good first issue label since I have a PR that shall eventually solve this one linked in above