search

ArduPilot / ardupilot

ArduPlane, ArduCopter, ArduRover, ArduSub source
http://ardupilot.org/
GNU General Public License v3.0
10.46k stars 17.1k forks source link

UAVCAN node id falsely identified as duplicate id #15477

Open flytrexguy opened 3 years ago

flytrexguy commented 3 years ago

Bug report

Issue details

The map of node's unique hardware id to UAVCAN node id is stored in persistent storage. So when connecting a different device with the same node id (after disconnecting the first device and rebooting AP of course) it will report it as duplicate id.

How to recreate the bug: Connect a UAVCAN device with a static node id. Then reboot AP and connect a different device (with a different hw id) with the same static node id.

Version Copter-4.0.4

Platform [ ] All [ ] AntennaTracker [X] Copter [ ] Plane [ ] Rover [ ] Submarine

Airframe type hex

Hardware type mRoControlZeroF7

Vkd4U2NtVkZOVg commented 3 years ago

Have the same issue with CUAV X7 Pro and UAVCAN pmu, I have two same pmu with the same id, one of them is broken, so I replace with the other one, but the PreArm: UC: Duplicate Node com.hex.here../xx pops up. So I have to disable the pmu by now. any idea how to solve this?

JacksonUAS commented 1 year ago

Was this ever resolved? Whats the work around? I think ive managed to recreate it :)

tridge commented 1 year ago

@JacksonUAS I've pinged @SchrodingersGat

David-OConnor commented 1 year ago

I'm getting this too. Anything I can do to help?

SchrodingersGat commented 1 year ago

From memory, @JacksonUAS resolved the issue by clearing the DNA cache

JacksonUAS commented 1 year ago

Never found a solution, clearing the cache solved it for a bit, then it came back. Went to Piccolo, no issues since.

magicrub commented 1 year ago

Can people pretty please state what version they are running when reporting a problem.

WickedShell commented 1 year ago

I've seen and resolved this on 4.0 aircraft with clearing the DNA cache.

So when connecting a different device with the same node id (after disconnecting the first device and rebooting AP of course) it will report it as duplicate id.

This sounds like it's working correctly? You used a different device with the same ID, that sounds like an error, what have I missed?

JacksonUAS commented 1 year ago

Connecting the same device, with the same node ID, produces the error as well.

On the test aircraft we were using, ESC power was separate to avionics. Booting up the ESCs after the FC, and populating them on the bus, with static IDs, generated new instances in the DNA cache....

David-OConnor commented 1 year ago

Same issue, re same device/same id.