ArduPilot / ardupilot

ArduPlane, ArduCopter, ArduRover, ArduSub source
http://ardupilot.org/
GNU General Public License v3.0
11.02k stars 17.57k forks source link

AP_Baro: KellerLD Vented Gauge Offset Should Update #18968

Closed ES-Alexander closed 2 years ago

ES-Alexander commented 3 years ago

Bug report

Issue details

The Vented Gauge type measures zero when pressure on both sides is equal. Currently the (enclosure internal pressure) offset is set to a constant value (standard atmospheric pressure at sea level), but it should actually be regularly updated (i.e. track the flight controller's absolute barometer), to handle changing pressure due to temperature etc.

This was brought up and discussed with @hendjoshsr71 here.

I'm planning to fix this, but it's in my TODO list as non-critical because at this stage there are no known users of vented-gauge KellerLD sensors (KellerLD is primarily (/only?) used by Sub at this point, which only uses the Sealed Gauge type). Vented Gauge was recently added as an option at initialisation because the rest of the sensor functionality is the same, and the gauge type is already being parsed from EEPROM.

Version

4.2.0 / master branch.

Platform [x] All [ ] AntennaTracker [ ] Copter [ ] Plane [ ] Rover [x] Submarine

Airframe type What type of airframe (flying wing, glider, hex, Y6, octa etc)

All/any

Hardware type What autopilot hardware was used? (Pixhawk, Cube, Pixracer, Navio2, etc)

All/any

hendjoshsr71 commented 2 years ago

Done! Thank you @shiv-tyagi !