Support DJI NAZA GPS+Compass

geofrancis commented 7 years ago

the dji naza gps/compass puts both over a single serial link not requiring the use of the i2c bus, if it was supported it would mean we could use dual external compass easily since there would be no i2c conflict.

inav have it working https://github.com/iNavFlight/inav/wiki/GPS--and-Compass-setup https://github.com/iNavFlight/inav/blob/master/src/main/io/gps_naza.c

third party compatable naza m8n's are plentiful on ebay.

proficnc commented 7 years ago

If you look at this, they are using I2C for both GPS and the compass.

This is a terrible idea! It's bad enough that we still use i2c for the compass.

The traffic we need on the ubx data for the gps would flood the i2c bus.

As far as cheap GPS's... define expensive? The Here is $48 with M8N, correct flash, battery backed ram, status LEDs, compass, and additional Saw filter /LNA

There are many cheap GPS's that use the correct serial port, and i2c that are even cheaper.

So I struggle to see how reducing the capability of the system is an improvement

OXINARF commented 7 years ago

@proficnc According to the inav documentation (and code looks like it too) this uses serial for both GPS and compass, not I2C.

I agree though that unless you want a fake/flawed GPS, it's harder to go cheaper than what we have already.

proficnc commented 7 years ago

Cool, looking at it yes, it looks like NAZA does... but it looks like that's NMEA.. which again is a regression

geofrancis commented 7 years ago

The point is that we can use the compass without i2c, with 3 compass's including internal you can get proper reduncancy and doesnt arducopter still use nmea for rtk gps units anyway?

OXINARF commented 7 years ago

Cool, looking at it yes, it looks like NAZA does... but it looks like that's NMEA.. which again is a regression

It doesn't look like NMEA, it looks like a custom protocol with a single message with all the information we need.

with 3 compass's including internal you can get proper reduncancy

How does I2C prevent you from having redundancy?

doesnt arducopter still use nmea for rtk gps units anyway?

Did it ever? The NMEA parser doesn't even support RTK fix status, all the other GPS drivers (that have RTK) do.

To conclude, I don't think this will be a priority for anyone in the dev team, but PRs are welcomed.

dhackens commented 7 years ago

HelloI think you have me confused with someone else .... I did not ask this question ? Dan H.

  From: Francisco Ferreira <notifications@github.com>

To: ArduPilot/ardupilot ardupilot@noreply.github.com Cc: Subscribed subscribed@noreply.github.com Sent: Sunday, February 5, 2017 6:25 AM Subject: Re: [ArduPilot/ardupilot] Support DJI NAZA GPS+Compass (#5664)

Cool, looking at it yes, it looks like NAZA does... but it looks like that's NMEA.. which again is a regression It doesn't look like NMEA, it looks like a custom protocol with a single message with all the information we need. with 3 compass's including internal you can get proper reduncancy How does I2C prevent you from having redundancy? doesnt arducopter still use nmea for rtk gps units anyway? Did it ever? The NMEA parser doesn't even support RTK fix status, all the other GPS drivers (that have RTK) do.To conclude, I don't think this will be a priority for anyone in the dev team, but PRs are welcomed.— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

OXINARF commented 7 years ago

@dhackens Nobody quoted you. Like your e-mail says you got a notification because you subscribed to this issue.

geofrancis commented 7 years ago

@OXINARF the i2c stops you plugging in more than 1 i2c compass or you get address conflicts, as far as i know there are no other compass's supported externally other than derivatives of the 5883l that all use the same address.

proficnc commented 7 years ago

There are heaps of compasses supported, in fact the Here+ has 4 I2C compasses on board, and you can plug two of them into a pixhawk 2 with no conflicts.

We support the BMM150, hmc5983, LIS3MDL, LSM303D, AK series, MPU9250...

geofrancis commented 7 years ago

you cant find any of them combined with a m8n apart from the hm5983 but it shares address as 5883l so you cant use them together hence the problem.

if you do some googling for the m8n you see there are only 2 flavours readily available the 588l/5983 one for apm/pixhawk and the naza compatable m8n there are just no other m8n/compass modules out there.

rmackay9 commented 7 years ago

This seems like a valid request. We generally try to support a wide variety of hardware. I have a pretty full plate so it's not likely that I'll get to this soon but perhaps someone else will have a look so it's fine for it to be here as a to-do item.

magicrub commented 7 years ago

My friend @Gregorydz is wanting to work on this. Has anyone else started? If so, would they like to collaborate? Otherwise, he'll be starting on it soon.

geofrancis commented 7 years ago

I can help with testing.

magicrub commented 7 years ago

@gregorydz have you had a chance to take a look at this?

Gregorydz commented 7 years ago

No unfortunately I have not yet, been bogged down by school stuff.

On Fri, Mar 10, 2017 at 3:02 PM, Tom Pittenger notifications@github.com wrote:

@gregorydz https://github.com/gregorydz have you had a chance to take a look at this?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ArduPilot/ardupilot/issues/5664#issuecomment-285809048, or mute the thread https://github.com/notifications/unsubscribe-auth/AIMqP7xK8kFZYnkU4byGUcqK_mHKNQHuks5rkdabgaJpZM4L3T1a .