search

ArduPilot / ardupilot

ArduPlane, ArduCopter, ArduRover, ArduSub source
http://ardupilot.org/
GNU General Public License v3.0
10.92k stars 17.41k forks source link

AP_Camera only send feedback message if autopilot is triggering the camera directly #7159

Open jmachuca77 opened 6 years ago

jmachuca77 commented 6 years ago

Issue details

Currently every time the autopilot sends a trigger message the feedback message is also sent. By the pixhawk. In cases where the camera is actually triggered by a secondary camera controller or a companion computer. Then that component should be responsible for sending the feedback message. Only in the case where there is no other component to trigger the camera, or if the feedback pin is used on the pixhawk, should the feedback message be sent.

I propose a parameter to enable or disable sending the feedback message.

Platform

[X] All [ ] AntennaTracker [ ] Copter [ ] Plane [ ] Rover [ ] Submarine

Airframe type

All Airframes

Hardware type

Not relevant to hardware

rmackay9 commented 6 years ago

I think maybe a CAMERA_TYPE parameter would be good. I think we will need different drivers for different cameras some time in the next year.

WickedShell commented 6 years ago

Also worth noting that if a feedback pin has been setup on the vehicle then I'd actually rather get a feedback message when we see a feedback event rather then continuously. (The feedback message needs some MAVLink2 extensions though to be more robust/useful)